Page MenuHomePhabricator

Move cancel/retry/free task queue actions to bin/worker
ClosedPublic

Authored by epriestley on Dec 6 2014, 4:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 15 2024, 11:12 PM
Unknown Object (File)
Feb 15 2024, 11:12 PM
Unknown Object (File)
Feb 14 2024, 9:41 PM
Unknown Object (File)
Feb 14 2024, 9:41 PM
Unknown Object (File)
Feb 14 2024, 9:41 PM
Unknown Object (File)
Feb 7 2024, 8:54 PM
Unknown Object (File)
Feb 1 2024, 7:16 PM
Unknown Object (File)
Dec 31 2023, 4:56 PM
Subscribers

Details

Summary

Fixes T6702. Ref T3554. Currently, tasks can be cancelled, retried and freed from the web UI by any logged in user.

This isn't appreciably dangerous (I can't come up with a way that a user could do anything security-affecting), but I think I probably intended this to be admin-only, but these actions should move to the CLI anyway.

Move them to the CLI. Lay some groundwork for some future bin/worker cancel --class SomeTaskClass, but don't implement that yet.

Test Plan

Used cancel, retry and free from the CLI. Hit all the error/success states.

Diff Detail

Repository
rP Phabricator
Branch
daemoncli
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3191
Build 3197: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Move cancel/retry/free task queue actions to bin/worker.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Dec 6 2014, 5:05 PM
This revision was automatically updated to reflect the committed changes.