Page MenuHomePhabricator

Transactions - fix bug in differential where older inlines weren't appearing
ClosedPublic

Authored by btrahan on Dec 5 2014, 6:19 PM.
Tags
None
Referenced Files
F11787316: D10935.diff
Tue, May 30, 10:49 AM
Unknown Object (File)
Sat, May 27, 2:32 PM
Unknown Object (File)
Sat, May 13, 3:49 PM
Unknown Object (File)
Sat, May 6, 3:27 AM
Unknown Object (File)
Thu, May 4, 6:40 PM
Unknown Object (File)
Thu, May 4, 6:40 PM
Unknown Object (File)
Thu, May 4, 2:19 PM
Unknown Object (File)
Apr 27 2023, 7:04 AM
Subscribers

Details

Summary

Fixes T6699. We need to "loadInlineComments" consistently, though for an unexpected reason - this mutates the $changesets to include all $changesets that have an associated inline comment, which is necessary to make them render properly.

Test Plan

Took a diff with inline comments and updated it, noting the inline comments disappeared. applied this patch and the inlines reappeared.

Diff Detail

Repository
rP Phabricator
Branch
T6699
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3185
Build 3191: [Placeholder Plan] Wait for 30 Seconds