Page MenuHomePhabricator

Transactions - fix pagination bug
ClosedPublic

Authored by btrahan on Dec 5 2014, 12:15 AM.
Tags
None
Referenced Files
F18198228: D10933.id26259.diff
Sun, Aug 17, 11:29 PM
F18183342: D10933.id26259.diff
Sat, Aug 16, 11:23 AM
F18107527: D10933.id26261.diff
Mon, Aug 11, 1:12 AM
F17886461: D10933.id.diff
Tue, Jul 29, 1:01 AM
F17851929: D10933.diff
Sun, Jul 27, 11:56 AM
F17620514: D10933.diff
Jul 9 2025, 8:46 PM
Unknown Object (File)
Jun 29 2025, 7:25 PM
Unknown Object (File)
Jun 2 2025, 10:39 AM
Subscribers

Details

Summary

Fixes T6694. Ref T4712. Turns out the logic here was slightly incorrect; we don't want to use the id of the last thing we hid but rather the first thing we show. I had garbage test data ("asdsadsadsa", etc) I guess so I didn't notice this.

Test Plan

made a new task where user a and user b alternated 3 comments each, cooperatively numbering them from 1 - 20. as both users, showed older transactions. pre-patch the issue described in T6694 occurred and post patch I saw the entire counting sequence.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - fix pagination bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2014, 12:46 AM
This revision was automatically updated to reflect the committed changes.