Page MenuHomePhabricator

Transactions - fix pagination bug
ClosedPublic

Authored by btrahan on Dec 5 2014, 12:15 AM.
Tags
None
Referenced Files
F13337074: D10933.diff
Wed, Jun 19, 9:03 AM
F13322226: D10933.diff
Fri, Jun 14, 7:45 AM
F13314298: D10933.id26259.diff
Tue, Jun 11, 6:47 PM
F13294674: D10933.diff
Wed, Jun 5, 6:14 PM
F13288237: D10933.diff
Tue, Jun 4, 10:02 AM
F13276248: D10933.diff
Fri, May 31, 5:44 AM
F13265139: D10933.id26261.diff
Tue, May 28, 1:32 AM
F13262463: D10933.diff
Mon, May 27, 2:10 AM
Subscribers

Details

Summary

Fixes T6694. Ref T4712. Turns out the logic here was slightly incorrect; we don't want to use the id of the last thing we hid but rather the first thing we show. I had garbage test data ("asdsadsadsa", etc) I guess so I didn't notice this.

Test Plan

made a new task where user a and user b alternated 3 comments each, cooperatively numbering them from 1 - 20. as both users, showed older transactions. pre-patch the issue described in T6694 occurred and post patch I saw the entire counting sequence.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - fix pagination bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2014, 12:46 AM
This revision was automatically updated to reflect the committed changes.