Page MenuHomePhabricator

Transactions - fix pagination bug
ClosedPublic

Authored by btrahan on Dec 5 2014, 12:15 AM.
Tags
None
Referenced Files
F15418536: D10933.id26261.diff
Thu, Mar 20, 11:54 PM
F15414653: D10933.id.diff
Thu, Mar 20, 1:49 AM
F15406108: D10933.diff
Tue, Mar 18, 12:08 PM
F15386056: D10933.id.diff
Fri, Mar 14, 11:57 PM
F15378252: D10933.id26261.diff
Thu, Mar 13, 1:30 PM
F15378251: D10933.id.diff
Thu, Mar 13, 1:30 PM
F15378250: D10933.diff
Thu, Mar 13, 1:30 PM
F15343112: D10933.id26261.diff
Sun, Mar 9, 10:12 PM
Subscribers

Details

Summary

Fixes T6694. Ref T4712. Turns out the logic here was slightly incorrect; we don't want to use the id of the last thing we hid but rather the first thing we show. I had garbage test data ("asdsadsadsa", etc) I guess so I didn't notice this.

Test Plan

made a new task where user a and user b alternated 3 comments each, cooperatively numbering them from 1 - 20. as both users, showed older transactions. pre-patch the issue described in T6694 occurred and post patch I saw the entire counting sequence.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - fix pagination bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2014, 12:46 AM
This revision was automatically updated to reflect the committed changes.