Page MenuHomePhabricator

Transactions - fix pagination bug
ClosedPublic

Authored by btrahan on Dec 5 2014, 12:15 AM.
Tags
None
Attached Files
F10754808: D10933.id26259.diff
Tue, May 24, 10:41 PM
F10754162: D10933.id.diff
Tue, May 24, 6:19 PM
Unknown Object (File)
Tue, May 24, 4:23 AM
Unknown Object (File)
Apr 14 2017, 1:00 AM
Unknown Object (File)
Apr 11 2017, 3:00 AM
Unknown Object (File)
Feb 14 2017, 1:49 AM
Unknown Object (File)
Feb 14 2017, 1:49 AM
Unknown Object (File)
Feb 14 2017, 1:49 AM
Subscribers

Details

Summary

Fixes T6694. Ref T4712. Turns out the logic here was slightly incorrect; we don't want to use the id of the last thing we hid but rather the first thing we show. I had garbage test data ("asdsadsadsa", etc) I guess so I didn't notice this.

Test Plan

made a new task where user a and user b alternated 3 comments each, cooperatively numbering them from 1 - 20. as both users, showed older transactions. pre-patch the issue described in T6694 occurred and post patch I saw the entire counting sequence.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - fix pagination bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2014, 12:46 AM
This revision was automatically updated to reflect the committed changes.