Page MenuHomePhabricator
Create Task
Maniphest T6694

Different users see different subset of comments on a Maniphest task
Closed, ResolvedPublic
Actions

Description

We've got a Maniphest task with about 35 comments on it. However, not all users see the same set of comments. I looked at what 3 different users are seeing. I see most of the comments, but one is missing for me. Another employee can see the one I can't, but she doesn't see one of the comments that I do see. A 3rd employee can see all the comments. We did refresh our screens and we did all click "show older changes".

The task in question does have a custom "Visible to" and "Editable by" policy on it. Both policies are set to allow all members of 2 particular project access. All members of those projects can see the task and most of the comments, but as noted above, different comments are missing for different users. It is also the case that the policy for this task changed a few times as different teams were added and/or removed.

There is client data in this bug so I'm not able to post screen shots here, but I'd be happy to do a Google hangout or some other kind of screen share and show one of your devs what we're seeing. Would also be happy to run some DB queries and pull out info that might help you debug (provided, of course, that it doesn't contain our client's info).

Here's some info from the DB that I imagine will be helpful:

mysql> select id, phid, viewPolicy, editPolicy from maniphest_task where id = 379;
+-----+--------------------------------+--------------------------------+--------------------------------+
| id  | phid                           | viewPolicy                     | editPolicy                     |
+-----+--------------------------------+--------------------------------+--------------------------------+
| 379 | PHID-TASK-ohryaocaq7mybmqe3c3r | PHID-PLCY-j6vwnxdwqxq35tjl6ra2 | PHID-PLCY-jowns5fip6e3zffyp57w |
+-----+--------------------------------+--------------------------------+--------------------------------+

mysql> select viewPolicy, editPolicy, transactionType from maniphest_transaction where objectPHID = 'PHID-TASK-ohryaocaq7mybmqe3c3r';
+------------+--------------------------------+------------------+
| viewPolicy | editPolicy                     | transactionType  |
+------------+--------------------------------+------------------+
| public     | PHID-USER-th45gzwtazm7dvpwpprm | title            |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | description      |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | status           |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | priority         |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | reassign         |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | ccs              |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | core:edge        |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | core:customfield |
| public     | PHID-USER-iiauggap6fo5jutog3qw | core:comment     |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | core:comment     |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | ccs              |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | core:comment     |
| public     | PHID-USER-iiauggap6fo5jutog3qw | core:comment     |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | reassign         |
| public     | PHID-USER-cr6jmq4eltuai37khehl | core:comment     |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | ccs              |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:view-policy |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:edit-policy |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | ccs              |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:edge        |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-iiauggap6fo5jutog3qw | core:comment     |
| public     | PHID-USER-cr6jmq4eltuai37khehl | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | ccs              |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-nhkvwuyez26jwy2zojr7 | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-nhkvwuyez26jwy2zojr7 | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | ccs              |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:view-policy |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:edit-policy |
| public     | PHID-USER-fsvhlyx42kfbrvseszpn | core:comment     |
| public     | PHID-USER-cr6jmq4eltuai37khehl | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-cr6jmq4eltuai37khehl | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-nhkvwuyez26jwy2zojr7 | core:comment     |
| public     | PHID-USER-iiauggap6fo5jutog3qw | core:comment     |
| public     | PHID-USER-nhkvwuyez26jwy2zojr7 | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-cr6jmq4eltuai37khehl | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-cr6jmq4eltuai37khehl | core:comment     |
| public     | PHID-USER-iiauggap6fo5jutog3qw | core:comment     |
| public     | PHID-USER-cr6jmq4eltuai37khehl | core:comment     |
| public     | PHID-USER-th45gzwtazm7dvpwpprm | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-cr6jmq4eltuai37khehl | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-j5psp2to2gbyo224525v | core:comment     |
| public     | PHID-USER-j5psp2to2gbyo224525v | ccs              |
| public     | PHID-USER-cr6jmq4eltuai37khehl | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-pkho3p4pfdh22kyfw6en | core:comment     |
| public     | PHID-USER-j5psp2to2gbyo224525v | core:comment     |
+------------+--------------------------------+------------------+

For my reference if you have follow up questions: the task is T379

Revisions and Commits

rP Phabricator
D10933rPa1a8083b935f Transactions - fix pagination bug

Related Objects

Event Timeline

oliverdain created this task.Dec 4 2014, 8:42 PM
oliverdain raised the priority of this task from to Needs Triage.
oliverdain updated the task description. (Show Details)
oliverdain added a subscriber: oliverdain.
oliverdain added a comment.Dec 4 2014, 8:46 PM

BTW:

Phabricator Version f6e635c8d279718dc9ad43fdb490630438f2cd44
Arcanist Version b46d4ed4ad01556a9400c836dc11cd1432d1f75b
libphutil Version 549aa1bf14851dcb348d63a3d40b28f376720a2e
epriestley added subscribers: btrahan, epriestley.Dec 4 2014, 8:51 PM

This is expected if the transactions which can not be seen are "<some user> mentioned this <on some other object>" transactions, and the hidden transactions are hidden because the viewers can not see the "<on some other object>" objects.

This is the only type of transaction we show selectively right now. If the phantom transactions are actual comments, this is a bug that's likely related to T4712, particularly if the oddness occurs only after clicking "Show Older Transactions".

qgil added a subscriber: qgil.Dec 4 2014, 10:35 PM
btrahan added a project: Transactions.Dec 4 2014, 10:43 PM

So are the transactions which can not be seen "<some user> mentioned this <on some other object>" transactions, and the hidden transactions are hidden because the viewers can not see the "<on some other object>" objects?

oliverdain added a comment.EditedDec 4 2014, 11:51 PM

I don't think the transactions are of that form. One is a comment I added directly to the ticket via the web UI. Here's s screen shot of that comment:

pasted_file (99×1 px, 21 KB)

Note that is says, "via web" and appears to be a comment directly on the ticket.

btrahan claimed this task.Dec 5 2014, 12:02 AM

Yeah, there's something generally wrong here...

btrahan triaged this task as High priority.Dec 5 2014, 12:02 AM
btrahan added a revision: D10933: Transactions - fix pagination bug.Dec 5 2014, 12:15 AM
btrahan closed this task as Resolved.Dec 5 2014, 1:21 AM
btrahan added a commit: rPa1a8083b935f: Transactions - fix pagination bug.

Closed by commit rPa1a8083b935f.

btrahan added a comment.Dec 5 2014, 1:22 AM

If you update to HEAD this should be resolved. Thanks a ton for the report and let us know if you see anything else...!

oliverdain added a comment.Dec 8 2014, 6:52 PM

Appears fixed. Thanks!!

Phabricator · Built by Phacility