Page MenuHomePhabricator

Transactions - fix pagination bug
ClosedPublic

Authored by btrahan on Dec 5 2014, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 4:52 AM
Unknown Object (File)
Wed, Mar 13, 9:42 PM
Unknown Object (File)
Wed, Mar 13, 9:39 PM
Unknown Object (File)
Thu, Mar 7, 10:36 AM
Unknown Object (File)
Thu, Mar 7, 9:38 AM
Unknown Object (File)
Tue, Mar 5, 6:04 AM
Unknown Object (File)
Mon, Mar 4, 4:57 PM
Unknown Object (File)
Mon, Mar 4, 2:26 PM
Subscribers

Details

Summary

Fixes T6694. Ref T4712. Turns out the logic here was slightly incorrect; we don't want to use the id of the last thing we hid but rather the first thing we show. I had garbage test data ("asdsadsadsa", etc) I guess so I didn't notice this.

Test Plan

made a new task where user a and user b alternated 3 comments each, cooperatively numbering them from 1 - 20. as both users, showed older transactions. pre-patch the issue described in T6694 occurred and post patch I saw the entire counting sequence.

Diff Detail

Repository
rP Phabricator
Branch
T6694
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3183
Build 3189: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactions - fix pagination bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 5 2014, 12:46 AM
This revision was automatically updated to reflect the committed changes.