Page MenuHomePhabricator

Transactions - land buildTransactionTimeline in a bunch more apps
ClosedPublic

Authored by btrahan on Dec 3 2014, 8:59 PM.
Tags
None
Referenced Files
F13485236: D10924.diff
Sat, Jul 20, 11:28 PM
F13484570: D10924.id26242.diff
Sat, Jul 20, 7:09 PM
F13480022: D10924.diff
Fri, Jul 19, 7:21 AM
F13463737: D10924.id26242.diff
Mon, Jul 15, 5:40 PM
F13460120: D10924.id.diff
Mon, Jul 15, 10:29 AM
F13450437: D10924.id26241.diff
Sat, Jul 13, 9:13 AM
F13417656: D10924.diff
Sun, Jul 7, 11:42 PM
F13411253: D10924.diff
Sat, Jul 6, 7:30 PM
Subscribers

Details

Summary

Ref T4712. Specifically...

  • Dashboards
    • two objects needed PhabricatorApplicationTransactionInterface
  • Macros
  • Paste
  • Phlux
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Files
    • one object needed PhabricatorApplicationTransactionInterface
  • Passphrase
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Drydock
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
Test Plan

foreach application, verify that the timeline(s) showed up correctly, including with appropriate setShouldTerminate-ness

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - land buildTransactionTimeline in a bunch more apps.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Dec 3 2014, 9:01 PM
This revision was automatically updated to reflect the committed changes.