Page MenuHomePhabricator

Transactions - land buildTransactionTimeline in a bunch more apps
ClosedPublic

Authored by btrahan on Dec 3 2014, 8:59 PM.
Tags
None
Referenced Files
F18033186: D10924.id26241.diff
Sun, Aug 3, 12:41 AM
F18029479: D10924.id26242.diff
Sat, Aug 2, 11:17 PM
F17997261: D10924.diff
Sat, Aug 2, 4:53 AM
F17924508: D10924.id.diff
Wed, Jul 30, 10:03 AM
F17913842: D10924.diff
Tue, Jul 29, 6:28 PM
Unknown Object (File)
Jul 3 2025, 10:43 AM
Unknown Object (File)
Jul 2 2025, 9:44 PM
Unknown Object (File)
Jun 18 2025, 10:09 PM
Subscribers

Details

Summary

Ref T4712. Specifically...

  • Dashboards
    • two objects needed PhabricatorApplicationTransactionInterface
  • Macros
  • Paste
  • Phlux
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Files
    • one object needed PhabricatorApplicationTransactionInterface
  • Passphrase
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Drydock
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
Test Plan

foreach application, verify that the timeline(s) showed up correctly, including with appropriate setShouldTerminate-ness

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - land buildTransactionTimeline in a bunch more apps.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Dec 3 2014, 9:01 PM
This revision was automatically updated to reflect the committed changes.