Differential D10924

Transactions - land buildTransactionTimeline in a bunch more apps
ClosedPublic
Actions

Authored by btrahan on Dec 3 2014, 8:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 1:19 PM

	Unknown Object (File)
	Thu, Dec 19, 1:19 PM

	Unknown Object (File)
	Fri, Dec 13, 9:17 AM

	Unknown Object (File)
	Fri, Dec 13, 9:17 AM

	Unknown Object (File)
	Fri, Dec 13, 8:56 AM

	Unknown Object (File)
	Fri, Dec 13, 7:33 AM

	Unknown Object (File)
	Fri, Dec 6, 4:23 AM

	Unknown Object (File)
	Thu, Dec 5, 12:46 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4712: Paginate transactions on objects once there are a huge number of them

Commits

Restricted Diffusion Commit
rP5e8600442d73: Transactions - land buildTransactionTimeline in a bunch more apps

Summary

Ref T4712. Specifically...

Dashboards
- two objects needed PhabricatorApplicationTransactionInterface
Macros
Paste
Phlux
- one object needed PhabricatorApplicationTransactionInterface
- added setShouldTerminate(true)
Files
- one object needed PhabricatorApplicationTransactionInterface
Passphrase
- one object needed PhabricatorApplicationTransactionInterface
- added setShouldTerminate(true)
Drydock
- one object needed PhabricatorApplicationTransactionInterface
- added setShouldTerminate(true)

Test Plan

foreach application, verify that the timeline(s) showed up correctly, including with appropriate setShouldTerminate-ness

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26241.Dec 3 2014, 8:59 PM

btrahan added a task: T4712: Paginate transactions on objects once there are a huge number of them.

btrahan retitled this revision from to Transactions - land buildTransactionTimeline in a bunch more apps.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 3 2014, 8:59 PM

Nice.

This revision is now accepted and ready to land.Dec 3 2014, 9:01 PM

Closed by commit rP5e8600442d73: Transactions - land buildTransactionTimeline in a bunch more apps (authored by btrahan, committed by btrahan). · Explain WhyDec 3 2014, 9:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

6 lines

applications/

dashboard/

controller/

PhabricatorDashboardHistoryController.php

22 lines

PhabricatorDashboardPanelViewController.php

25 lines

storage/

PhabricatorDashboard.php

17 lines

PhabricatorDashboardPanel.php

17 lines

drydock/

controller/

DrydockBlueprintViewController.php

17 lines

storage/

DrydockBlueprint.php

17 lines

files/

controller/

PhabricatorFileInfoController.php

29 lines

storage/

PhabricatorFile.php

17 lines

macro/

controller/

PhabricatorMacroViewController.php

24 lines

passphrase/

controller/

PassphraseCredentialViewController.php

16 lines

storage/

PassphraseCredential.php

22 lines

paste/

controller/

PhabricatorPasteViewController.php

24 lines

phlux/

controller/

PhluxViewController.php

19 lines

storage/

PhluxVariable.php

17 lines

Diff 26242

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardHistoryController.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...

src/applications/drydock/controller/DrydockBlueprintViewController.php

Loading...

src/applications/drydock/storage/DrydockBlueprint.php

Loading...

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...

src/applications/files/storage/PhabricatorFile.php

Loading...

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...

src/applications/passphrase/storage/PassphraseCredential.php

Loading...

src/applications/paste/controller/PhabricatorPasteViewController.php

Loading...

src/applications/phlux/controller/PhluxViewController.php

Loading...

src/applications/phlux/storage/PhluxVariable.php

Loading...