Page MenuHomePhabricator

Transactions - land buildTransactionTimeline in a bunch more apps
ClosedPublic

Authored by btrahan on Dec 3 2014, 8:59 PM.
Tags
None
Referenced Files
F15467983: D10924.id26241.diff
Thu, Apr 3, 7:02 PM
F15419864: D10924.id26242.diff
Fri, Mar 21, 9:32 AM
F15417649: D10924.id26241.diff
Thu, Mar 20, 5:46 PM
F15415180: D10924.diff
Thu, Mar 20, 4:39 AM
F15410953: D10924.id.diff
Wed, Mar 19, 8:44 AM
F15407448: D10924.diff
Tue, Mar 18, 5:34 PM
F15378229: D10924.id26242.diff
Mar 13 2025, 1:29 PM
F15378227: D10924.diff
Mar 13 2025, 1:29 PM
Subscribers

Details

Summary

Ref T4712. Specifically...

  • Dashboards
    • two objects needed PhabricatorApplicationTransactionInterface
  • Macros
  • Paste
  • Phlux
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Files
    • one object needed PhabricatorApplicationTransactionInterface
  • Passphrase
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Drydock
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
Test Plan

foreach application, verify that the timeline(s) showed up correctly, including with appropriate setShouldTerminate-ness

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - land buildTransactionTimeline in a bunch more apps.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Dec 3 2014, 9:01 PM
This revision was automatically updated to reflect the committed changes.