Page MenuHomePhabricator

Transactions - land buildTransactionTimeline in a bunch more apps
ClosedPublic

Authored by btrahan on Dec 3 2014, 8:59 PM.
Tags
None
Referenced Files
F13303921: D10924.diff
Sat, Jun 8, 7:34 AM
F13287609: D10924.diff
Tue, Jun 4, 9:01 AM
F13275116: D10924.diff
Fri, May 31, 4:25 AM
F13261178: D10924.diff
Mon, May 27, 12:46 AM
F13259488: D10924.id26241.diff
Sun, May 26, 9:16 PM
F13243713: D10924.diff
Thu, May 23, 4:09 AM
F13223269: D10924.diff
Sun, May 19, 4:26 AM
F13198822: D10924.diff
May 13 2024, 10:08 AM
Subscribers

Details

Summary

Ref T4712. Specifically...

  • Dashboards
    • two objects needed PhabricatorApplicationTransactionInterface
  • Macros
  • Paste
  • Phlux
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Files
    • one object needed PhabricatorApplicationTransactionInterface
  • Passphrase
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Drydock
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
Test Plan

foreach application, verify that the timeline(s) showed up correctly, including with appropriate setShouldTerminate-ness

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - land buildTransactionTimeline in a bunch more apps.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Dec 3 2014, 9:01 PM
This revision was automatically updated to reflect the committed changes.