Page MenuHomePhabricator

Transactions - land buildTransactionTimeline in a bunch more apps
ClosedPublic

Authored by btrahan on Dec 3 2014, 8:59 PM.
Tags
None
Attached Files
Unknown Object (File)
Apr 11 2017, 1:07 PM
Unknown Object (File)
Jan 20 2017, 9:18 PM
Unknown Object (File)
Nov 17 2016, 9:19 AM
Unknown Object (File)
Nov 7 2016, 2:01 PM
Unknown Object (File)
Nov 6 2016, 1:05 PM
Unknown Object (File)
Sep 17 2016, 11:53 AM
Unknown Object (File)
Sep 15 2016, 4:52 PM
Unknown Object (File)
Sep 14 2016, 5:19 AM
Subscribers

Details

Summary

Ref T4712. Specifically...

  • Dashboards
    • two objects needed PhabricatorApplicationTransactionInterface
  • Macros
  • Paste
  • Phlux
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Files
    • one object needed PhabricatorApplicationTransactionInterface
  • Passphrase
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
  • Drydock
    • one object needed PhabricatorApplicationTransactionInterface
    • added setShouldTerminate(true)
Test Plan

foreach application, verify that the timeline(s) showed up correctly, including with appropriate setShouldTerminate-ness

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - land buildTransactionTimeline in a bunch more apps.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Dec 3 2014, 9:01 PM
This revision was automatically updated to reflect the committed changes.