Page MenuHomePhabricator

Transactions - deploy buildTransactionTimeline against a few more applications

Authored by btrahan on Dec 2 2014, 10:24 PM.
Referenced Files
F13483096: D10921.diff
Sat, Jul 20, 6:53 AM
F13477361: D10921.id26232.diff
Fri, Jul 19, 12:47 AM
F13468585: D10921.diff
Wed, Jul 17, 2:27 AM
F13457582: D10921.diff
Sun, Jul 14, 6:53 PM
Sat, Jul 13, 5:01 PM
F13444824: D10921.diff
Fri, Jul 12, 11:37 PM
F13423120: D10921.diff
Mon, Jul 8, 11:55 PM
F13404246: D10921.diff
Fri, Jul 5, 1:07 PM



Ref T4712. Thus far, it seems that most "non-standard" things can be done pretty easily in the controller. Aside from deploying, this diff had to fix a few bugs / missing implementations of stuff.

(Notably, PhabricatorAuthProviderConfig, HeraldRule, PhabricatorSlowvotePoll, and AlmanacNetwork needed to implement PhabricatorApplicationTransactionInterface, PhabricatorAuthAuthProviderPHIDType had to be added, and a rendering bug in transactions of type PhabricatorOAuth2AuthProvider had to be fixed.)

Test Plan

Almanac - looked at binding, device, network, and service view controllers and verified timeline displayed properly. Herald - looked at a rule and verified timeline. Slowvote - looked at a vote and verified timeline. Auth - looked at an auth provider (Facebook) and verified proper display of transactions within timeline.

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 3166
Build 3172: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactiona - deploy buildTransactionTimeline against a few more applications.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Nice, this all looks good to me.


(This should be unnecessary, I think, since they're the same objects.)

This revision is now accepted and ready to land.Dec 2 2014, 10:27 PM
btrahan retitled this revision from Transactiona - deploy buildTransactionTimeline against a few more applications to Transactions - deploy buildTransactionTimeline against a few more applications.Dec 2 2014, 10:30 PM
btrahan edited edge metadata.
  • lose unnecessary setTransactions() call
  • stuff I thought was in the first diff but I guess isn't:
    • remove deprecated AUTH constant
    • fix a typo on getTransactions (was missing an s)
This revision was automatically updated to reflect the committed changes.