Transactions - deploy buildTransactionTimeline against a few more applications
ClosedPublic
Actions

Authored by btrahan on Dec 2 2014, 10:24 PM.

Details

Reviewers

Maniphest Tasks

T4712: Paginate transactions on objects once there are a huge number of them

Commits

Restricted Diffusion Commit
rP69cc5df6456b: Transactions - deploy buildTransactionTimeline against a few more applications

Summary

Ref T4712. Thus far, it seems that most "non-standard" things can be done pretty easily in the controller. Aside from deploying, this diff had to fix a few bugs / missing implementations of stuff.

(Notably, PhabricatorAuthProviderConfig, HeraldRule, PhabricatorSlowvotePoll, and AlmanacNetwork needed to implement PhabricatorApplicationTransactionInterface, PhabricatorAuthAuthProviderPHIDType had to be added, and a rendering bug in transactions of type PhabricatorOAuth2AuthProvider had to be fixed.)

Test Plan

Almanac - looked at binding, device, network, and service view controllers and verified timeline displayed properly. Herald - looked at a rule and verified timeline. Slowvote - looked at a vote and verified timeline. Auth - looked at an auth provider (Facebook) and verified proper display of transactions within timeline.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26232.Dec 2 2014, 10:24 PM

btrahan added a task: T4712: Paginate transactions on objects once there are a huge number of them.

btrahan retitled this revision from to Transactiona - deploy buildTransactionTimeline against a few more applications.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 2 2014, 10:24 PM

btrahan updated this object.Dec 2 2014, 10:25 PM

Nice, this all looks good to me.

src/applications/auth/controller/config/PhabricatorAuthEditController.php
314–315	(This should be unnecessary, I think, since they're the same objects.)

This revision is now accepted and ready to land.Dec 2 2014, 10:27 PM

btrahan retitled this revision from Transactiona - deploy buildTransactionTimeline against a few more applications to Transactions - deploy buildTransactionTimeline against a few more applications.Dec 2 2014, 10:30 PM

btrahan edited edge metadata.

lose unnecessary setTransactions() call
stuff I thought was in the first diff but I guess isn't:
- remove deprecated AUTH constant
- fix a typo on getTransactions (was missing an s)