Page MenuHomePhabricator

Differential - fix bug destroying diffs
ClosedPublic

Authored by btrahan on Dec 1 2014, 8:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 15 2024, 11:46 PM
Unknown Object (File)
Feb 11 2024, 11:25 AM
Unknown Object (File)
Feb 6 2024, 2:22 PM
Unknown Object (File)
Feb 3 2024, 1:25 AM
Unknown Object (File)
Feb 2 2024, 7:45 PM
Unknown Object (File)
Jan 28 2024, 10:20 AM
Unknown Object (File)
Jan 27 2024, 10:48 PM
Unknown Object (File)
Jan 27 2024, 10:20 PM
Subscribers

Details

Summary

I think this was a "hacked" sub thing that never got updated when we switched to a real editor? I am not 100% sure how these methods are used, so please let me know if I should expand my test plan. Fixes T6659.

Test Plan

made a diff from the web ui, looked up the phid from mysql, ran bin/remove destroy <phid>, and it worked!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Differential - fix bug destroying diffs.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Yep, these look correct to me. I think the test plan is sufficient.

This revision is now accepted and ready to land.Dec 1 2014, 8:29 PM
This revision was automatically updated to reflect the committed changes.