Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15550283
D10896.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D10896.diff
View Options
Index: src/lib/control/typeahead/normalizer/TypeaheadNormalizer.js
===================================================================
--- src/lib/control/typeahead/normalizer/TypeaheadNormalizer.js
+++ src/lib/control/typeahead/normalizer/TypeaheadNormalizer.js
@@ -18,7 +18,7 @@
*/
normalize : function(str) {
return ('' + str)
- .toLocaleLowerCase()
+ .toLowerCase()
.replace(/[\.,-\/#!$%\^&\*;:{}=\-_`~()]/g, '')
.replace(/ +/g, ' ')
.replace(/^\s*|\s*$/g, '');
Index: src/lib/control/typeahead/source/TypeaheadSource.js
===================================================================
--- src/lib/control/typeahead/source/TypeaheadSource.js
+++ src/lib/control/typeahead/source/TypeaheadSource.js
@@ -286,10 +286,15 @@
objs.push(this._raw[hits[ii]]);
}
- var default_comparator = function(u, v) {
- var key_u = u.sort || u.name;
- var key_v = v.sort || v.name;
- return key_u.localeCompare(key_v);
+ var default_comparator = function(u, v) {
+ var key_u = u.sort || u.name;
+ var key_v = v.sort || v.name;
+ if (key_u < key_v) {
+ return -1;
+ } else if (key_u > key_v) {
+ return 1;
+ }
+ return 0;
};
var handler = this.getSortHandler() || function(value, list, cmp) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Apr 28, 10:49 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7223913
Default Alt Text
D10896.diff (1 KB)
Attached To
Mode
D10896: Typeahead: Do not use locale-specific comparisons
Attached
Detach File
Event Timeline
Log In to Comment