Differential D10882

Closing as a duplicate should use "closed" iconography
ClosedPublic
Actions

Authored by chad on Nov 19 2014, 11:34 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T6500: Duplicated tasks should be marked more visibly as duplicates

Commits

Restricted Diffusion Commit
rP6dc29724e710: Closing as a duplicate should use "closed" iconography

Summary

Uses the check icon for closed, which is the primary action taken.

Test Plan

Close as a duplicate, seen new icon.

Diff Detail

Repository

rP Phabricator

Branch

merge_icon

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3106
Build 3112: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 26135.Nov 19 2014, 11:34 PM

chad retitled this revision from to Closing as a duplicate should use "closed" iconography.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 19 2014, 11:34 PM

chad edited the test plan for this revision. (Show Details)Nov 19 2014, 11:34 PM

Harbormaster completed remote builds in B3106: Diff 26135.Nov 19 2014, 11:34 PM

epriestley accepted this revision.Nov 19 2014, 11:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 19 2014, 11:36 PM

Closed by commit rP6dc29724e710: Closing as a duplicate should use "closed" iconography (authored by chad, committed by chad). · Explain WhyNov 19 2014, 11:37 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T6500: Duplicated tasks should be marked more visibly as duplicates.Nov 19 2014, 11:43 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

storage/

ManiphestTransaction.php

1 line

Diff 26135

View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Closing as a duplicate should use "closed" iconographyClosedPublicActions