Differential D10875

Differential - allow setting viewPolicy from web ui during diff creation process
ClosedPublic
Actions

Authored by btrahan on Nov 19 2014, 8:00 PM.

Tags

None

Referenced Files

	F14012117: D10875.id26119.diff
	Fri, Nov 1, 7:20 AM

	F14012111: D10875.id.diff
	Fri, Nov 1, 7:19 AM

	F14012110: D10875.id26120.diff
	Fri, Nov 1, 7:19 AM

	F14011847: D10875.diff
	Fri, Nov 1, 5:30 AM

	F14011756: D10875.diff
	Fri, Nov 1, 5:13 AM

	F13989575: D10875.diff
	Mon, Oct 21, 9:29 PM

	F13974284: D10875.id26120.diff
	Oct 18 2024, 4:55 AM

	Unknown Object (File)
	Oct 11 2024, 5:41 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T6237: Use ApplicationTransactions properly in Diff creation
T6152: Show explicit policy controls on web diff creation workflow

Commits

Restricted Diffusion Commit
rP435085862892: Differential - allow setting viewPolicy from web ui during diff creation process

Summary

Fixes T6152, T6237. This introduces a viewPolicy column to the DifferentialDiff, and re-jiggers the DifferentialDiff policy implementation such that things behave as before once associated with a revision, else use the DifferentialDiff policy column value.

Test Plan

made a diff with a non-standard view policy and noted that policy was still selected in the revision step. arc lint.

Diff Detail

Repository

Branch

T6152

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3095
Build 3101: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 26119.Nov 19 2014, 8:00 PM

btrahan added tasks: T6152: Show explicit policy controls on web diff creation workflow, T6237: Use ApplicationTransactions properly in Diff creation.

btrahan retitled this revision from to Differential - allow setting viewPolicy from web ui during diff creation process.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 19 2014, 8:00 PM

Harbormaster completed remote builds in B3095: Diff 26119.Nov 19 2014, 8:00 PM

Nice, looks perfect to me.

This revision is now accepted and ready to land.Nov 19 2014, 8:04 PM

Closed by commit rP435085862892: Differential - allow setting viewPolicy from web ui during diff creation process (authored by btrahan, committed by btrahan). · Explain WhyNov 19 2014, 8:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20141119.differential.diff.policy.sql

5 lines

src/

applications/

differential/

__tests__/

DifferentialParseRenderTestCase.php

4 lines

conduit/

DifferentialCreateDiffConduitAPIMethod.php

2 lines

DifferentialCreateRawDiffConduitAPIMethod.php

9 lines

controller/

DifferentialDiffCreateController.php

22 lines

DifferentialRevisionEditController.php

7 lines

editor/

DifferentialDiffEditor.php

5 lines

parser/

__tests__/

DifferentialHunkParserTestCase.php

4 lines

query/

DifferentialDiffQuery.php

1 line

storage/

DifferentialDiff.php

39 lines

__tests__/

DifferentialDiffTestCase.php

5 lines

diffusion/

controller/

DiffusionChangeController.php

4 lines

DiffusionCommitController.php

1 line

DiffusionDiffController.php

4 lines

data/

DiffusionPathChange.php

6 lines

engine/

DiffusionCommitHookEngine.php

4 lines

herald/

adapter/

HeraldCommitAdapter.php

4 lines

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

2 lines

infrastructure/

diff/

PhabricatorDifferenceEngine.php

4 lines

Diff 26119

resources/sql/autopatches/20141119.differential.diff.policy.sql

Loading...

src/applications/differential/tests/DifferentialParseRenderTestCase.php

Loading...

src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php

Loading...

src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php

Loading...

src/applications/differential/controller/DifferentialDiffCreateController.php

Loading...

src/applications/differential/controller/DifferentialRevisionEditController.php

Loading...

src/applications/differential/editor/DifferentialDiffEditor.php

Loading...

src/applications/differential/parser/tests/DifferentialHunkParserTestCase.php

Loading...

src/applications/differential/query/DifferentialDiffQuery.php

Loading...

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/differential/storage/tests/DifferentialDiffTestCase.php

Loading...

src/applications/diffusion/controller/DiffusionChangeController.php

Loading...

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...

src/applications/diffusion/controller/DiffusionDiffController.php

Loading...

src/applications/diffusion/data/DiffusionPathChange.php

Loading...

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...

src/infrastructure/diff/PhabricatorDifferenceEngine.php

Loading...