Page MenuHomePhabricator

Allow config get to work when db is not functional
ClosedPublic

Authored by skroll on Nov 14 2014, 4:56 PM.
Tags
None
Referenced Files
F14100396: D10851.id26050.diff
Tue, Nov 26, 2:01 PM
Unknown Object (File)
Mon, Nov 25, 11:23 AM
Unknown Object (File)
Sat, Nov 16, 5:27 PM
Unknown Object (File)
Tue, Nov 12, 10:01 PM
Unknown Object (File)
Tue, Nov 12, 9:38 PM
Unknown Object (File)
Sat, Nov 9, 8:43 AM
Unknown Object (File)
Thu, Nov 7, 3:53 AM
Unknown Object (File)
Sat, Nov 2, 8:04 AM
Subscribers
Tokens
"Like" token, awarded by chad.

Details

Summary

Fixes T6554.

Test Plan

Run bin/config get mysql.host when no db is functional. Should not get an exception, but should see:

{
  "config" : [
    {
      "key"       : "mysql.host",
      "source"    : "local",
      "value"     : null,
      "status"    : "unset",
      "errorInfo" : null
    },
    {
      "key"       : "mysql.host",
      "source"    : "database",
      "value"     : null,
      "status"    : "error",
      "errorInfo" : "Database source is not configured properly"
    }
  ]
}

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

skroll retitled this revision from to Allow config get to work when db is not functional.
skroll updated this object.
skroll edited the test plan for this revision. (Show Details)

I already did, or did it not associate it with my account?

EDIT: Signed it again.

epriestley added a reviewer: epriestley.

Looks like it's good now. Thanks!

This revision is now accepted and ready to land.Nov 14 2014, 5:11 PM
This revision was automatically updated to reflect the committed changes.