Fix HTML email section breaks
ClosedPublic
Actions

Authored by chad on Nov 7 2014, 6:12 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T6481: HTML mail no longer has newline after link sections

Commits

Restricted Diffusion Commit
rPbcb360ea2bd4: Fix HTML email section breaks

Summary

Fixes T6481. Provides better section handling.

Test Plan

Test an email with multiple sections, multiple mail platforms.

Screen_Shot_2014-11-07_at_10.10.13_AM.png (1×1 px, 160 KB)

Diff Detail

Repository

rP Phabricator

Branch

mail-links

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2984
Build 2988: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 25940.Nov 7 2014, 6:12 PM

chad retitled this revision from to Fix HTML email section breaks.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T6481: HTML mail no longer has newline after link sections.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 7 2014, 6:12 PM

Harbormaster completed remote builds in B2984: Diff 25940.Nov 7 2014, 6:13 PM

epriestley accepted this revision.Nov 7 2014, 6:13 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 7 2014, 6:13 PM

chad edited the test plan for this revision. (Show Details)Nov 7 2014, 6:14 PM

chad edited edge metadata.

Closed by commit rPbcb360ea2bd4: Fix HTML email section breaks (authored by chad, committed by chad). · Explain WhyNov 7 2014, 6:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

metamta/

view/

PhabricatorMetaMTAMailBody.php

9 lines

Diff 25940

View Options

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

Fix HTML email section breaksClosedPublicActions