Page MenuHomePhabricator

Make `./bin/diviner generate` more fault tolerant
ClosedPublic

Authored by joshuaspence on Nov 7 2014, 12:43 AM.
Tags
None
Referenced Files
F14087741: D10803.diff
Sat, Nov 23, 11:35 PM
Unknown Object (File)
Sun, Oct 27, 6:27 AM
Unknown Object (File)
Oct 22 2024, 12:07 PM
Unknown Object (File)
Oct 19 2024, 11:41 PM
Unknown Object (File)
Sep 30 2024, 5:43 AM
Unknown Object (File)
Sep 27 2024, 9:42 AM
Unknown Object (File)
Sep 27 2024, 9:40 AM
Unknown Object (File)
Sep 27 2024, 9:39 AM
Subscribers

Details

Summary

Allow ./bin/diviner generate to continue even if there is an exception throw processing an atom. This allows Diviner documentation to be generated for PHP source code that cannot be parsed with XHPAST.

Test Plan

Ran ./bin/diviner generate on a PHP repository which previously throw an XHPASTSyntaxErrorException.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2976
Build 2980: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Make `./bin/diviner generate` more fault tolerant.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2014, 10:58 PM
This revision was automatically updated to reflect the committed changes.