diviner generate` more fault tolerant
ClosedPublic
Actions

Authored by joshuaspence on Nov 7 2014, 12:43 AM.

Details

Reviewers

epriestley
btrahan

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPbcd78716df0f: Make `./bin/diviner generate` more fault tolerant

Summary

Allow ./bin/diviner generate to continue even if there is an exception throw processing an atom. This allows Diviner documentation to be generated for PHP source code that cannot be parsed with XHPAST.

Test Plan

Ran ./bin/diviner generate on a PHP repository which previously throw an XHPASTSyntaxErrorException.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 25928.Nov 7 2014, 12:43 AM

joshuaspence retitled this revision from to Make `./bin/diviner generate` more fault tolerant.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added reviewers: epriestley, btrahan.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 7 2014, 12:43 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B2976: Diff 25928.Nov 7 2014, 12:43 AM

epriestley accepted this revision.Nov 7 2014, 10:58 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 7 2014, 10:58 PM

Closed by commit rPbcd78716df0f: Make `./bin/diviner generate` more fault tolerant (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 8 2014, 3:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diviner/

workflow/

DivinerGenerateWorkflow.php

18 lines

Diff 25968

View Options

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

Make `./bin/diviner generate` more fault tolerantClosedPublicActions