Differential D10775

Make loading large changesets slightly easier
ClosedPublic
Actions

Authored by chad on Nov 3 2014, 12:01 AM.

Tags

None

Referenced Files

	F14352320: D10775.id25860.diff
	Thu, Dec 19, 1:36 PM

	Unknown Object (File)
	Fri, Dec 13, 4:54 PM

	Unknown Object (File)
	Thu, Dec 12, 11:38 PM

	Unknown Object (File)
	Tue, Dec 10, 5:30 AM

	Unknown Object (File)
	Sun, Dec 8, 11:23 AM

	Unknown Object (File)
	Sat, Nov 30, 7:47 AM

	Unknown Object (File)
	Nov 19 2024, 9:14 AM

	Unknown Object (File)
	Nov 10 2024, 1:01 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T3942: Make messaging for 100+ click-to-load changeset behavior more clear

Commits

Restricted Diffusion Commit
rPf5235f7e09eb: Make loading large changesets slightly easier

Summary

Fixes T3942, turns the load links into buttons.

Test Plan

Set my limit to 1, test page.

Diff Detail

Repository

Branch

large-button

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2933
Build 2937: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 25860.Nov 3 2014, 12:01 AM

chad retitled this revision from to Make loading large changesets slightly easier.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T3942: Make messaging for 100+ click-to-load changeset behavior more clear.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 3 2014, 12:01 AM

Screen_Shot_2014-11-02_at_3.56.51_PM.png (440×1 px, 53 KB)

Harbormaster completed remote builds in B2933: Diff 25860.Nov 3 2014, 12:02 AM

epriestley accepted this revision.Nov 3 2014, 12:58 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/differential/controller/DifferentialRevisionViewController.php
143	The "Diff" language is technically accurate: a revision may have several diffs, some of which are small and some of which are large. Only the large ones would trigger this prompt.

This revision is now accepted and ready to land.Nov 3 2014, 12:58 PM

fixed language

Closed by commit rPf5235f7e09eb: Make loading large changesets slightly easier (authored by chad, committed by chad). · Explain WhyNov 3 2014, 5:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

7 lines

view/

DifferentialChangesetListView.php

3 lines

Diff 25860

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...

src/applications/differential/view/DifferentialChangesetListView.php

Loading...