Page MenuHomePhabricator

Make messaging for 100+ click-to-load changeset behavior more clear
Closed, ResolvedPublic

Event Timeline

klimek raised the priority of this task from to Needs Triage.
klimek updated the task description. (Show Details)
klimek added a subscriber: klimek.

Can you walk me through what you're seeing vs what you expect? Maybe this wasn't clear enough (it's in the middle of the page):

Screen_Shot_2013-10-11_at_11.22.35_AM.png (225×975 px, 22 KB)

In particular, these are the expected behaviors, and the behaviors I observe are consistent:

  • When a change affects more than 100 files, we don't load the changes by default. Instead, we render the notice above, and show the metadata for each change.
  • You can click "Load" to load individual changes, or "Show All Files Inline" to load everything normally despite the number of changesets.
    • Sometimes these changes are things like mass find/replace, where only a few files are really relevant to the review.
    • Even if you do eventually want to examine each file, being able to load the page to interact with it in other ways (e.g., respond to comments) without having to load 300 changesets is often valuable.
  • When I click "Show All Files Inline", everything loads for me.

Ah, sorry - I overlooked the notice because it was in the middle of the comments section (which was already large) and the file section.

I mistook the "Load" link for a "Loading..." link :P, so this is PEBKAC.
Might have saved me to have the notice at the top of the change, instead of in between, but then again, perhaps I would just have refused to switch on my brain in that case, too ;)

Yeah, I think we could clean up the messaging a bunch here -- the warning isn't terribly visible, is kind of spatially unrelated to the thing it actually affects, and the "Load" text could easily provide more context and look different from "Loading".

epriestley renamed this task from Phab does not finish loading large changes to Make messaging for 100+ click-to-load changeset behavior more clear.Oct 11 2013, 6:44 PM
epriestley triaged this task as Normal priority.
epriestley added a project: Differential.
epriestley added a subscriber: chad.

@chad, I'll take a stab at this, but you might have some ideas for it. Users have missed the element in https://secure.phabricator.com/T3942#3 a few times. I'm basically planning to:

  • Make it larger/more colorful and put put it right above the changesets.
  • Make the link a button.
  • Make the "Load" links inline either buttons or colored or something.
chad moved this task from Backlog to Short Term on the Design board.