Page MenuHomePhabricator

Retroactively populate Phriction mailKey column
ClosedPublic

Authored by epriestley on Nov 7 2014, 12:41 PM.

Details

Summary

Fixes T6487. Ref T1191. Ref T4029. D10756 introduced, but did not populate, this column. This can cause it to fill with "\0\0\0..." after adjustment.

Regardless of the adjustment issue, it's nice to populate this column anyway because there's no fundamental reason an object can't have mail sent about it without being saved first, even though it may not practically be possible in the codebase today.

Test Plan
  • Ran storage upgrade, saw the column populate for older documents.
  • Forced a couple of keys to bad values (too short or with "\0") and saw the migration fix them.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Retroactively populate Phriction mailKey column.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Sorry; I thought this would just work since afaik mails would be sent via the editor iff the object was saved first. Whoops.

This revision is now accepted and ready to land.Nov 7 2014, 4:53 PM
This revision was automatically updated to reflect the committed changes.