Paths

Table of Contentst

Differential D10804

Retroactively populate Phriction mailKey column
ClosedPublic
Actions

Authored by epriestley on Nov 7 2014, 12:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 4, 5:19 AM

	Unknown Object (File)
	Tue, Dec 3, 8:43 PM

	Unknown Object (File)
	Mon, Dec 2, 10:42 AM

	Unknown Object (File)
	Wed, Nov 27, 6:34 PM

	Unknown Object (File)
	Sun, Nov 24, 5:16 AM

	Unknown Object (File)
	Tue, Nov 19, 8:08 AM

	Unknown Object (File)
	Nov 11 2024, 7:33 AM

	Unknown Object (File)
	Nov 3 2024, 6:58 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T4029: Support policies on Phriction wiki articles
T1191: Comments are truncated at first non-base-plane character
T6487: Historic Phriction documents do not have mailKeys populated

Commits

Restricted Diffusion Commit
rPe58259b4f52b: Retroactively populate Phriction mailKey column

Summary

Fixes T6487. Ref T1191. Ref T4029. D10756 introduced, but did not populate, this column. This can cause it to fill with "\0\0\0..." after adjustment.

Regardless of the adjustment issue, it's nice to populate this column anyway because there's no fundamental reason an object can't have mail sent about it without being saved first, even though it may not practically be possible in the codebase today.

Test Plan

Ran storage upgrade, saw the column populate for older documents.
Forced a couple of keys to bad values (too short or with "\0") and saw the migration fix them.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25929.Nov 7 2014, 12:41 PM

epriestley retitled this revision from to Retroactively populate Phriction mailKey column.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T6487: Historic Phriction documents do not have mailKeys populated, T1191: Comments are truncated at first non-base-plane character.

Herald added a subscriber: epriestley. · View Herald TranscriptNov 7 2014, 12:41 PM

epriestley updated this object.Nov 7 2014, 12:41 PM

epriestley added a task: T4029: Support policies on Phriction wiki articles.

Harbormaster completed remote builds in B2977: Diff 25929.Nov 7 2014, 12:41 PM

epriestley mentioned this in T1191: Comments are truncated at first non-base-plane character.Nov 7 2014, 12:42 PM

Sorry; I thought this would just work since afaik mails would be sent via the editor iff the object was saved first. Whoops.

This revision is now accepted and ready to land.Nov 7 2014, 4:53 PM

Closed by commit rPe58259b4f52b: Retroactively populate Phriction mailKey column (authored by epriestley, committed by epriestley). · Explain WhyNov 7 2014, 5:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20141107.phriction.popkeys.php

29 lines

Diff 25937

resources/sql/autopatches/20141107.phriction.popkeys.php

Loading...