Paths

Table of Contentst

Differential D10653

Extend `ArcanistXHPASTLinter::LINT_KEYWORD_CASING`
ClosedPublic
Actions

Authored by joshuaspence on Oct 7 2014, 9:51 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCf44a6e00a724: Extend `ArcanistXHPASTLinter::LINT_KEYWORD_CASING`

Summary

Extend ArcanistXHPASTLinter::LINT_KEYWORD_CASING to include the class keyword.

Test Plan

I can't really added a test case for this without getting "XHP19 Class-Filename Mismatch".

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2767
Build 2771: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25587.Oct 7 2014, 9:51 PM

joshuaspence retitled this revision from to Extend `ArcanistXHPASTLinter::LINT_KEYWORD_CASING`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 7 2014, 9:51 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B2767: Diff 25587.Oct 7 2014, 9:52 PM

epriestley accepted this revision.Oct 7 2014, 9:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 7 2014, 9:53 PM

Closed by commit rARCf44a6e00a724: Extend `ArcanistXHPASTLinter::LINT_KEYWORD_CASING` (authored by joshuaspence, committed by joshuaspence).Oct 7 2014, 9:55 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D10656: Fix `LINT_KEYWORD_CASING` for `class` keyword.Oct 7 2014, 10:28 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

1 line

Diff 25587

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Extend `ArcanistXHPASTLinter::LINT_KEYWORD_CASING`ClosedPublicActions