Page MenuHomePhabricator

Set autoload to false on CURLFile in HTTPSFuture
ClosedPublic

Authored by chad on Oct 7 2014, 6:09 PM.
Tags
None
Referenced Files
F14047279: D10650.diff
Thu, Nov 14, 3:18 AM
F14043205: D10650.id25580.diff
Tue, Nov 12, 8:14 AM
Unknown Object (File)
Oct 6 2024, 11:36 PM
Unknown Object (File)
Oct 6 2024, 11:36 PM
Unknown Object (File)
Oct 6 2024, 11:35 PM
Unknown Object (File)
Oct 6 2024, 11:22 PM
Unknown Object (File)
Sep 18 2024, 8:29 PM
Unknown Object (File)
Sep 6 2024, 9:54 AM
Subscribers

Details

Summary

Fixes T6264, I assume this is correct after grepping through the codebase.

Test Plan

Reload in sandbox, eyeball text, not sure what else to do.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Set autoload to false on CURLFile in HTTPSFuture.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 7 2014, 6:14 PM

Strange. No idea where I landed this, but arc did close the branch.

Landing current branch 'class-exists'.
Switched to branch master. Updating branch...
The following commit(s) will be landed:

e9be1b0 Set autoload to false on CURLFile in HTTPSFuture

Switched to branch class-exists. Identifying and merging...
Landing revision 'D10650: Set autoload to false on CURLFile in HTTPSFuture'...
BUILDS PASSED  Harbormaster builds for the active diff completed successfully. 
Merging class-exists into master
Already up-to-date.
Pushing change...

Counting objects: 11, done.
Delta compression using up to 8 threads. 
Compressing objects: 100% (6/6), done. 
Writing objects: 100% (6/6), 728 bytes | 0 bytes/s, done.
Total 6 (delta 5), reused 0 (delta 0)
remote: This repository moved. Please use the new location:
remote:   https://github.com/phacility/libphutil.git
To git@github.com:facebook/libphutil.git
 984269c..160eeba  master -> master

Cleaning up feature branch...
(Use `git checkout -b 'class-exists' 'e9be1b0190b4b29cf10606807b11f6f3cd9b6f4c'` if you want it back.)
Done.

Do I just check it out again and land to secure?

You pushed to GitHub, and then Phabricator immediately wiped out your changes by mirroring.

Use git remote set-url origin ssh://dweller@secure.phabricator.com/diffusion/PHU/libphutil.git in your libphutil/, then git push if you still have the commit.

If you don't still have it, do arc patch --nobranch D10650, then git push.

This revision was automatically updated to reflect the committed changes.