Check for CURLFile is broken in HTTPSFuture
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	aroravishal
	Oct 7 2014, 5:49 PM

Description

Specifically, I'm talking about:
https://secure.phabricator.com/diffusion/PHU/browse/master/src/future/http/HTTPSFuture.php;984269c6a3a377508fa4bf408ba725530e819b80$548

That line currently states:
if (class_exists('CURLFile')) {

By default, class_exists will autoload the class. This fails on PHP version < 5.5, so it defeats the purpose of the check. The check should really be:
if (class_exists('CURLFile', false)) {

Could someone do this quick fix?

Revisions and Commits

rPHU libphutil
	D10650	rPHU160eeba602bf Set autoload to false on CURLFile in HTTPSFuture

Event Timeline

aroravishal created this task.Oct 7 2014, 5:49 PM

aroravishal raised the priority of this task from to Needs Triage.

aroravishal updated the task description. (Show Details)

aroravishal added a project: libphutil.

aroravishal added a subscriber: aroravishal.

chad added a revision: D10650: Set autoload to false on CURLFile in HTTPSFuture.Oct 7 2014, 6:09 PM

Closed by commit rPHU160eeba602bf.

Check for CURLFile is broken in HTTPSFutureClosed, ResolvedPublicActions

Description

Revisions and Commits

Event Timeline

Check for CURLFile is broken in HTTPSFuture
Closed, ResolvedPublic
Actions