Page MenuHomePhabricator
Create Task
Maniphest T6264

Check for CURLFile is broken in HTTPSFuture
Closed, ResolvedPublic
Actions

Description

Specifically, I'm talking about:
https://secure.phabricator.com/diffusion/PHU/browse/master/src/future/http/HTTPSFuture.php;984269c6a3a377508fa4bf408ba725530e819b80$548

That line currently states:
if (class_exists('CURLFile')) {

By default, class_exists will autoload the class. This fails on PHP version < 5.5, so it defeats the purpose of the check. The check should really be:
if (class_exists('CURLFile', false)) {

Could someone do this quick fix?

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

aroravishal created this task.Oct 7 2014, 5:49 PM
aroravishal raised the priority of this task from to Needs Triage.
aroravishal updated the task description. (Show Details)
aroravishal added a project: libphutil.
aroravishal added a subscriber: aroravishal.
chad added a revision: Restricted Differential Revision.Oct 7 2014, 6:09 PM
chad closed this task as Resolved.Oct 7 2014, 7:26 PM
chad added a commit: Restricted Diffusion Commit.

Closed by commit rPHU160eeba602bf.

Phabricator · Built by Phacility