Page MenuHomePhabricator

Configuration - re-jigger how we handle bad configuration files
ClosedPublic

Authored by btrahan on Oct 6 2014, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 6:32 PM
Unknown Object (File)
Fri, Dec 20, 10:14 PM
Unknown Object (File)
Thu, Dec 12, 8:33 PM
Unknown Object (File)
Dec 9 2024, 10:15 PM
Unknown Object (File)
Dec 2 2024, 9:45 PM
Unknown Object (File)
Dec 2 2024, 12:45 AM
Unknown Object (File)
Nov 26 2024, 7:10 AM
Unknown Object (File)
Nov 20 2024, 6:05 PM
Subscribers

Details

Summary

just explicitly check if the file doesn't exist *first*, and then do the standard include thing with the more generic error if that doesn't work. Fixes T6255.

Test Plan

re-started apache and phabricator still worked; will ask csilvers to give it a whirl too

Diff Detail

Repository
rP Phabricator
Branch
T6255
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2755
Build 2759: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Configuration - re-jigger how we handle bad configuration files.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2014, 8:15 PM
This revision was automatically updated to reflect the committed changes.