Page MenuHomePhabricator

Configuration - re-jigger how we handle bad configuration files
ClosedPublic

Authored by btrahan on Oct 6 2014, 8:14 PM.
Tags
None
Referenced Files
F18765826: D10643.id25558.diff
Tue, Oct 7, 1:17 PM
F18764583: D10643.id.diff
Tue, Oct 7, 6:42 AM
F18761178: D10643.diff
Mon, Oct 6, 12:44 PM
F18737625: D10643.id.diff
Wed, Oct 1, 11:41 AM
F18650448: D10643.id25557.diff
Sep 21 2025, 12:46 AM
F18610329: D10643.diff
Sep 14 2025, 4:31 AM
F18589746: D10643.diff
Sep 12 2025, 4:10 AM
F18481597: D10643.diff
Sep 3 2025, 12:44 PM
Subscribers

Details

Summary

just explicitly check if the file doesn't exist *first*, and then do the standard include thing with the more generic error if that doesn't work. Fixes T6255.

Test Plan

re-started apache and phabricator still worked; will ask csilvers to give it a whirl too

Diff Detail

Repository
rP Phabricator
Branch
T6255
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2755
Build 2759: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Configuration - re-jigger how we handle bad configuration files.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2014, 8:15 PM
This revision was automatically updated to reflect the committed changes.