Page MenuHomePhabricator

Fix incorrect maniphest.update conduit UI
ClosedPublic

Authored by chad on Oct 6 2014, 5:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 3:21 PM
Unknown Object (File)
Thu, Dec 19, 5:03 PM
Unknown Object (File)
Fri, Dec 6, 7:08 PM
Unknown Object (File)
Fri, Dec 6, 3:56 AM
Unknown Object (File)
Fri, Nov 29, 3:20 PM
Unknown Object (File)
Fri, Nov 29, 3:20 PM
Unknown Object (File)
Fri, Nov 29, 2:47 PM
Unknown Object (File)
Nov 21 2024, 3:53 AM
Subscribers

Details

Summary

Fixes T6254 and renames status as string. Though maybe this should go through formatStringConstants?

Test Plan

Reload Conduit page, see new text.

Diff Detail

Repository
rP Phabricator
Branch
mani-conduit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2748
Build 2752: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Fix incorrect maniphest.update conduit UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.

The types (like "optional string") should not be pht()'d. They will be properly typechecked in some future version of the API, and the typechecker will have no idea what to do with an "el stringo optionale".

This revision now requires changes to proceed.Oct 6 2014, 5:28 PM
chad edited edge metadata.
  • remove phts
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2014, 6:06 PM
This revision was automatically updated to reflect the committed changes.