Page MenuHomePhabricator
Differential D10637

Fix incorrect maniphest.update conduit UI
ClosedPublic
Actions

Authored by chad on Oct 6 2014, 5:02 PM.
Tags
None
Referenced Files
F13176549: D10637.diff
Wed, May 8, 2:59 PM
Unknown Object (File)
Tue, May 7, 7:52 AM
Unknown Object (File)
Sat, May 4, 2:14 PM
Unknown Object (File)
Fri, May 3, 6:45 AM
Unknown Object (File)
Wed, May 1, 11:18 PM
Unknown Object (File)
Wed, May 1, 6:06 PM
Unknown Object (File)
Tue, Apr 30, 3:58 PM
Unknown Object (File)
Thu, Apr 25, 1:31 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T6254: Error in maniphest.update conduit form
Commits
Restricted Diffusion Commit
rP923f625130cd: Fix incorrect maniphest.update conduit UI
Summary

Fixes T6254 and renames status as string. Though maybe this should go through formatStringConstants?

Test Plan

Reload Conduit page, see new text.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 25545.Oct 6 2014, 5:02 PM
chad retitled this revision from to Fix incorrect maniphest.update conduit UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T6254: Error in maniphest.update conduit form.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 6 2014, 5:02 PM
Harbormaster completed remote builds in B2748: Diff 25545.Oct 6 2014, 5:03 PM
epriestley requested changes to this revision.Oct 6 2014, 5:28 PM
epriestley edited edge metadata.

The types (like "optional string") should not be pht()'d. They will be properly typechecked in some future version of the API, and the typechecker will have no idea what to do with an "el stringo optionale".

This revision now requires changes to proceed.Oct 6 2014, 5:28 PM
chad updated this revision to Diff 25549.Oct 6 2014, 6:05 PM
chad edited edge metadata.
  • remove phts
epriestley accepted this revision.Oct 6 2014, 6:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2014, 6:06 PM
Harbormaster completed remote builds in B2749: Diff 25549.Oct 6 2014, 6:06 PM
Closed by commit rP923f625130cd: Fix incorrect maniphest.update conduit UI (authored by chad, committed by chad).Oct 6 2014, 6:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
conduit/
2 lines

Diff 25550

View Options

src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility