Correct column mutations for old versions of MySQL
ClosedPublic
Actions

Authored by epriestley on Oct 2 2014, 5:44 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character

Commits

Restricted Diffusion Commit
rPd67b7f0f47c4: Correct column mutations for old versions of MySQL

Summary

Ref T1191. Although I fixed some of the mutations earlier (in D10598), I missed the column mutations under old versions of MySQL. In particular, this isn't valid:

ALTER TABLE ... MODIFY columnName VARCHAR(64) COLLATE binary

Issue the permitted version of this instead, which is:

ALTER TABLE ... MODIFY columnName VARBINARY(64)

Also fixed an issue where a clean schema had the wrong nullability for a column in the draft table. Force it to the expected nullability.

The other trick here is around the one column with a FULLTEXT index on it, which needs a little massaging.

Test Plan

Forced my local install to return false for utf8mb4 support.
Did a clean adjust into binary columns.
Poked around, added emoji to things.
Reverted the fake check and did a clean adjust into utf8mb4 columns.
Emoji survived.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25514.Oct 2 2014, 5:44 PM

epriestley retitled this revision from to Correct column mutations for old versions of MySQL.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T1191: Comments are truncated at first non-base-plane character.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 2 2014, 5:44 PM

Harbormaster completed remote builds in B2725: Diff 25514.Oct 2 2014, 5:45 PM

Applying this and running storage/adjust vs. mysql 5.1 worked nicely
Afterwards "Database issues/status" is all green. Running adjust again tells me it found no issues and the db columns seem to be correct (just manually checked a few).
The emoji commit however still generates the 'mysql will silently truncate' error in validateUTF8String