Quiet utf8mb4 warnings when establish MySQL connections
ClosedPublic
Actions

Authored by epriestley on Oct 2 2014, 3:48 PM.

Details

Reviewers

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character
T6228: Error log spew after failing to set utf8mb4 charset

Commits

rPHUb7c05df35726: Quiet utf8mb4 warnings when establish MySQL connections

Summary

Fixes T6228. Ref T1191. Some versions of things spew warnings on these calls; I can't reproduce it locally but @fabe reports this resolving it for him in T6228.

Test Plan

Still works fine locally, but no surprises there.

Diff Detail

Repository

rPHU libphutil

Branch

quiet

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:136	XHP45	PHP Compatibility

Unit

No Test Coverage

Build Status

Buildable 2721
Build 2725: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25503.Oct 2 2014, 3:48 PM

epriestley retitled this revision from to Quiet utf8mb4 warnings when establish MySQL connections.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T6228: Error log spew after failing to set utf8mb4 charset, T1191: Comments are truncated at first non-base-plane character.

epriestley added a subscriber: fabe.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 2 2014, 3:48 PM

Harbormaster completed remote builds in B2721: Diff 25503.Oct 2 2014, 3:49 PM

btrahan accepted this revision.Oct 2 2014, 4:32 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php
77	should we silence it here too or at this point is cascading failure desirable?

This revision is now accepted and ready to land.Oct 2 2014, 4:32 PM

epriestley added inline comments.Oct 2 2014, 4:47 PM

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php
77	Yeah, it's probably good if this screams. Possibly we should check it for failure and throw explicitly, but I don't want to make T1191 any more involved than it already is and the old code hasn't had issues. In theory this shouldn't really be able to fail without the connection above failing or the next action we take also failing.