Page MenuHomePhabricator

Quiet utf8mb4 warnings when establish MySQL connections
ClosedPublic

Authored by epriestley on Oct 2 2014, 3:48 PM.

Details

Summary

Fixes T6228. Ref T1191. Some versions of things spew warnings on these calls; I can't reproduce it locally but @fabe reports this resolving it for him in T6228.

Test Plan

Still works fine locally, but no surprises there.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Quiet utf8mb4 warnings when establish MySQL connections.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: fabe.
btrahan edited edge metadata.
btrahan added inline comments.
src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php
77

should we silence it here too or at this point is cascading failure desirable?

This revision is now accepted and ready to land.Oct 2 2014, 4:32 PM
src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php
77

Yeah, it's probably good if this screams. Possibly we should check it for failure and throw explicitly, but I don't want to make T1191 any more involved than it already is and the old code hasn't had issues. In theory this shouldn't really be able to fail without the connection above failing or the next action we take also failing.

This revision was automatically updated to reflect the committed changes.