Page MenuHomePhabricator

Convert SavedQuery / NamedQuery to text, not bytes
ClosedPublic

Authored by epriestley on Oct 1 2014, 4:57 PM.
Tags
None
Referenced Files
F17333712: D10614.id.diff
Fri, Jun 27, 10:02 AM
F17327868: D10614.id25488.diff
Fri, Jun 27, 4:17 AM
F17327242: D10614.id25483.diff
Fri, Jun 27, 3:24 AM
Unknown Object (File)
May 8 2025, 12:02 AM
Unknown Object (File)
Apr 28 2025, 7:40 AM
Unknown Object (File)
Apr 21 2025, 11:56 PM
Unknown Object (File)
Apr 20 2025, 8:32 PM
Unknown Object (File)
Apr 13 2025, 3:30 AM
Subscribers

Details

Summary

Ref T1191. Similar issue to D10613. This column usually has a hash exactly 12 bytes long, but sometimes stores an internal builtin query name like "open", "all", etc. It might be nice to promote those to 12-byte hashes of a consistent length eventually, but for now just make this a variable-length column.

Test Plan

Ran migration, no longer saw issues with reordering builtin saved searches.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Convert SavedQuery / NamedQuery to text, not bytes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
This revision was automatically updated to reflect the committed changes.