Page MenuHomePhabricator

Convert SavedQuery / NamedQuery to text, not bytes
ClosedPublic

Authored by epriestley on Oct 1 2014, 4:57 PM.

Details

Summary

Ref T1191. Similar issue to D10613. This column usually has a hash exactly 12 bytes long, but sometimes stores an internal builtin query name like "open", "all", etc. It might be nice to promote those to 12-byte hashes of a consistent length eventually, but for now just make this a variable-length column.

Test Plan

Ran migration, no longer saw issues with reordering builtin saved searches.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Convert SavedQuery / NamedQuery to text, not bytes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
This revision was automatically updated to reflect the committed changes.