Differential D10614

Convert SavedQuery / NamedQuery to text, not bytes
ClosedPublic
Actions

Authored by epriestley on Oct 1 2014, 4:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 8:15 AM

	Unknown Object (File)
	Thu, Apr 11, 7:22 AM

	Unknown Object (File)
	Tue, Apr 9, 4:02 AM

	Unknown Object (File)
	Tue, Apr 2, 5:47 AM

	Unknown Object (File)
	Tue, Apr 2, 5:47 AM

	Unknown Object (File)
	Tue, Apr 2, 5:47 AM

	Unknown Object (File)
	Mon, Apr 1, 6:33 PM

	Unknown Object (File)
	Sun, Mar 31, 3:55 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character

Commits

Restricted Diffusion Commit
rP4eb439964003: Convert SavedQuery / NamedQuery to text, not bytes

Summary

Ref T1191. Similar issue to D10613. This column usually has a hash exactly 12 bytes long, but sometimes stores an internal builtin query name like "open", "all", etc. It might be nice to promote those to 12-byte hashes of a consistent length eventually, but for now just make this a variable-length column.

Test Plan

Ran migration, no longer saw issues with reordering builtin saved searches.

Diff Detail

Repository

Branch

utf4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2708
Build 2712: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25483.Oct 1 2014, 4:57 PM

epriestley retitled this revision from to Convert SavedQuery / NamedQuery to text, not bytes.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T1191: Comments are truncated at first non-base-plane character.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 1 2014, 4:57 PM

Harbormaster completed remote builds in B2708: Diff 25483.Oct 1 2014, 4:58 PM

Closed by commit rP4eb439964003: Convert SavedQuery / NamedQuery to text, not bytes (authored by epriestley, committed by epriestley).Oct 1 2014, 5:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

storage/

PhabricatorNamedQuery.php

2 lines

PhabricatorSavedQuery.php

2 lines

Diff 25483

src/applications/search/storage/PhabricatorNamedQuery.php

Loading...

src/applications/search/storage/PhabricatorSavedQuery.php

Loading...