Page MenuHomePhabricator

Convert DivinerLiveSymbol to text, not bytes
ClosedPublic

Authored by epriestley on Oct 1 2014, 4:48 PM.
Tags
None
Referenced Files
F15412543: D10613.diff
Wed, Mar 19, 1:35 PM
F15384781: D10613.id25482.diff
Fri, Mar 14, 8:48 PM
F15309090: D10613.diff
Thu, Mar 6, 6:53 AM
Unknown Object (File)
Feb 23 2025, 6:33 PM
Unknown Object (File)
Feb 7 2025, 11:34 PM
Unknown Object (File)
Feb 7 2025, 11:34 PM
Unknown Object (File)
Feb 7 2025, 11:34 PM
Unknown Object (File)
Jan 28 2025, 8:11 AM
Subscribers

Details

Summary

Ref T1191. The bytes types are BINARY(...), which is fixed-length and zero-pads. These hashes are not 64 characters long, so migrating them to binary ends up with a bunch of zero-padding.

Instead, migrate them to text so we drop the zero padding. It would be vaguely nice to either introduce a varbytes type (ick) or change the hash size to a standard size (nicer) eventually, but this isn't very important.

Test Plan

Will adjust secure.phabricator.com.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable