Page MenuHomePhabricator

Convert DivinerLiveSymbol to text, not bytes
ClosedPublic

Authored by epriestley on Oct 1 2014, 4:48 PM.
Tags
None
Referenced Files
F18791665: D10613.id.diff
Thu, Oct 16, 4:39 PM
F18791605: D10613.diff
Thu, Oct 16, 4:09 PM
F18760783: D10613.id.diff
Mon, Oct 6, 10:25 AM
F18756235: D10613.diff
Sun, Oct 5, 10:20 AM
F18737620: D10613.id25487.diff
Wed, Oct 1, 11:39 AM
F18700995: D10613.id25482.diff
Sat, Sep 27, 4:43 PM
F18700988: D10613.id25487.diff
Sat, Sep 27, 4:43 PM
F18684299: D10613.diff
Fri, Sep 26, 9:03 AM
Subscribers

Details

Summary

Ref T1191. The bytes types are BINARY(...), which is fixed-length and zero-pads. These hashes are not 64 characters long, so migrating them to binary ends up with a bunch of zero-padding.

Instead, migrate them to text so we drop the zero padding. It would be vaguely nice to either introduce a varbytes type (ick) or change the hash size to a standard size (nicer) eventually, but this isn't very important.

Test Plan

Will adjust secure.phabricator.com.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable