Page MenuHomePhabricator

Convert DivinerLiveSymbol to text, not bytes
ClosedPublic

Authored by epriestley on Oct 1 2014, 4:48 PM.
Tags
None
Referenced Files
F18626053: D10613.diff
Tue, Sep 16, 12:14 AM
F18622430: D10613.diff
Mon, Sep 15, 11:51 AM
F18622407: D10613.diff
Mon, Sep 15, 11:41 AM
F18585287: D10613.diff
Thu, Sep 11, 2:50 PM
F18585259: D10613.diff
Thu, Sep 11, 2:48 PM
F18585257: D10613.diff
Thu, Sep 11, 2:48 PM
F18456193: D10613.id.diff
Mon, Sep 1, 10:27 AM
F18435473: D10613.diff
Sun, Aug 31, 10:07 AM
Subscribers

Details

Summary

Ref T1191. The bytes types are BINARY(...), which is fixed-length and zero-pads. These hashes are not 64 characters long, so migrating them to binary ends up with a bunch of zero-padding.

Instead, migrate them to text so we drop the zero padding. It would be vaguely nice to either introduce a varbytes type (ick) or change the hash size to a standard size (nicer) eventually, but this isn't very important.

Test Plan

Will adjust secure.phabricator.com.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable