Page MenuHomePhabricator

Convert DivinerLiveSymbol to text, not bytes
ClosedPublic

Authored by epriestley on Oct 1 2014, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 19, 9:08 PM
Unknown Object (File)
Mon, Aug 17, 9:50 AM
Unknown Object (File)
Sat, Aug 15, 6:26 PM
Unknown Object (File)
Jun 30 2026, 3:47 PM
Unknown Object (File)
Jun 30 2026, 3:46 PM
Unknown Object (File)
Jun 30 2026, 2:44 PM
Unknown Object (File)
Jun 27 2026, 2:19 AM
Unknown Object (File)
Jun 22 2026, 2:55 PM
Subscribers

Details

Summary

Ref T1191. The bytes types are BINARY(...), which is fixed-length and zero-pads. These hashes are not 64 characters long, so migrating them to binary ends up with a bunch of zero-padding.

Instead, migrate them to text so we drop the zero padding. It would be vaguely nice to either introduce a varbytes type (ick) or change the hash size to a standard size (nicer) eventually, but this isn't very important.

Test Plan

Will adjust secure.phabricator.com.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable