Page MenuHomePhabricator

Convert DivinerLiveSymbol to text, not bytes
ClosedPublic

Authored by epriestley on Oct 1 2014, 4:48 PM.
Tags
None
Referenced Files
F12852490: D10613.diff
Fri, Mar 29, 7:25 AM
Unknown Object (File)
Mon, Mar 25, 7:16 PM
Unknown Object (File)
Mon, Mar 25, 7:16 PM
Unknown Object (File)
Mon, Mar 25, 7:16 PM
Unknown Object (File)
Thu, Mar 21, 5:41 AM
Unknown Object (File)
Thu, Mar 21, 3:04 AM
Unknown Object (File)
Mon, Mar 18, 4:54 PM
Unknown Object (File)
Sat, Mar 16, 4:37 AM
Subscribers

Details

Summary

Ref T1191. The bytes types are BINARY(...), which is fixed-length and zero-pads. These hashes are not 64 characters long, so migrating them to binary ends up with a bunch of zero-padding.

Instead, migrate them to text so we drop the zero padding. It would be vaguely nice to either introduce a varbytes type (ick) or change the hash size to a standard size (nicer) eventually, but this isn't very important.

Test Plan

Will adjust secure.phabricator.com.

Diff Detail

Repository
rP Phabricator
Branch
utf3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2707
Build 2711: [Placeholder Plan] Wait for 30 Seconds