Page MenuHomePhabricator

Destroy surplus columns
ClosedPublic

Authored by epriestley on Sep 27 2014, 11:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 6:58 PM
Unknown Object (File)
Mon, Mar 25, 6:58 PM
Unknown Object (File)
Mon, Mar 25, 6:58 PM
Unknown Object (File)
Mon, Mar 25, 4:18 PM
Unknown Object (File)
Sat, Mar 16, 4:37 AM
Unknown Object (File)
Jan 24 2024, 2:16 AM
Unknown Object (File)
Jan 16 2024, 12:40 AM
Unknown Object (File)
Jan 16 2024, 12:39 AM

Details

Summary

Ref T1191. This destroys surplus columns:

  • Pholio's transaction comments have a mockID column, but this is not used. The imageID column is used instead.
  • Phragment has an unused description column.
  • Releeph has an unused summary column.
Test Plan
  • Grepped for usage of these columns.
  • Checked that these exist in production, too.
  • Ran upgrades.
  • Added Pholio inline comments.
  • Saw fewer warnings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Destroy surplus columns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 4:50 PM
This revision was automatically updated to reflect the committed changes.