HomePhabricator

Add missing expected keys and uniqueness

Description

Add missing expected keys and uniqueness

Summary:
Ref T1191.

  • Adds definitions for missing keys and keys with wrong uniqueness. Generally, I defined these before fixing the key query to actually pull all keys and support uniqueness.
  • Moves "key uniqueness" to note severity; this is fixable (probably?) and there are no remaining issues.
  • Moves "Missing Key" to note severity; missing keys are fixable and all remaining missing keys are really missing (either missing edge keys, or missing PHID keys):

Screen_Shot_2014-09-27_at_3.04.42_PM.png (716×1 px, 131 KB)

  • Moves "Surplus Key" to note seveirty; surplus keys are fixable all remaining surplus keys are really surplus (duplicate key in Harbormaster, key on unused column in Worker):

Screen_Shot_2014-09-27_at_3.50.24_PM.png (68×1 px, 15 KB)

Test Plan:

  • Vetted missing/surplus/unique messages.
  • 146 issues remaining.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10590

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Oct 1 2014, 2:53 PM
Reviewer
btrahan
Differential Revision
D10590: Add missing expected keys and uniqueness
Parents
rP2880732a49a8: Generate expected schemata for Search
Branches
Unknown
Tags
Unknown
Tasks
T1191: Comments are truncated at first non-base-plane character