Page MenuHomePhabricator

Destroy surplus columns
ClosedPublic

Authored by epriestley on Sep 27 2014, 11:12 PM.
Tags
None
Referenced Files
F14475940: D10591.id25465.diff
Fri, Dec 27, 9:55 PM
Unknown Object (File)
Sun, Dec 22, 3:13 AM
Unknown Object (File)
Sat, Dec 21, 2:22 PM
Unknown Object (File)
Sat, Dec 21, 2:04 PM
Unknown Object (File)
Fri, Dec 20, 12:09 AM
Unknown Object (File)
Tue, Dec 17, 6:49 PM
Unknown Object (File)
Mon, Dec 16, 1:24 AM
Unknown Object (File)
Wed, Dec 11, 10:35 PM

Details

Summary

Ref T1191. This destroys surplus columns:

  • Pholio's transaction comments have a mockID column, but this is not used. The imageID column is used instead.
  • Phragment has an unused description column.
  • Releeph has an unused summary column.
Test Plan
  • Grepped for usage of these columns.
  • Checked that these exist in production, too.
  • Ran upgrades.
  • Added Pholio inline comments.
  • Saw fewer warnings.

Diff Detail

Repository
rP Phabricator
Branch
utfx17
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2680
Build 2684: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Destroy surplus columns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 4:50 PM
This revision was automatically updated to reflect the committed changes.