Page MenuHomePhabricator
Differential D10579

Remove Date from Diff hovercard
ClosedPublic
Actions

Authored by chad on Sep 26 2014, 9:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 12:24 AM
Unknown Object (File)
Mon, Jan 27, 5:58 PM
Unknown Object (File)
Fri, Jan 24, 6:21 PM
Unknown Object (File)
Thu, Jan 23, 8:02 PM
Unknown Object (File)
Thu, Jan 23, 5:01 PM
Unknown Object (File)
Thu, Jan 23, 5:01 PM
Unknown Object (File)
Thu, Jan 23, 5:01 PM
Unknown Object (File)
Thu, Jan 23, 5:01 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Doubloon" token, awarded by btrahan.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T6184: Incorrect date shown on hover
Commits
Restricted Diffusion Commit
rP3ce107fc429e: Remove Date from Diff hovercard
Summary

Fixes T6184. On a Revision page we don't show the date as an important piece of information, so it's also not likely useful on a Hovercard (and confusing as to what the date means).

Test Plan

Hover over a linked Diff

Diff Detail

Repository
rP Phabricator
Branch
hovercard-date
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2664
Build 2668: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 25406.Sep 26 2014, 9:25 PM
chad retitled this revision from to Remove Date from Diff hovercard.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T6184: Incorrect date shown on hover.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptSep 26 2014, 9:25 PM
Harbormaster completed remote builds in B2664: Diff 25406.Sep 26 2014, 9:25 PM
epriestley accepted this revision.Sep 26 2014, 9:26 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 26 2014, 9:26 PM
Closed by commit rP3ce107fc429e: Remove Date from Diff hovercard (authored by chad, committed by chad).Sep 26 2014, 9:27 PM
This revision was automatically updated to reflect the committed changes.
btrahan awarded a token.Sep 27 2014, 5:33 AM

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
event/
3 lines

Diff 25406

View Options

src/applications/differential/event/DifferentialHovercardEventListener.php

Loading...
Phabricator · Built by Phacility