Moves to PHUIObjectBox, removes old CSS
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rPf74082aecd06: Update AphrontRequestFailure to common display libs
Pull up 404 page.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- 404-box
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 2663 Build 2667: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Can we get rid of all this stuff and just return a dialog (return $this->newDialog()->...)?
I think the only issue is that dialogs look weird with no buttons, but we could either fix that or add a "Rats!" button that takes you home.
| webroot/rsrc/css/aphront/request-failure-view.css | ||
|---|---|---|
| 28 | I presume then these buttons aren't in use anywhere? I grepped but did come up with anything. If all AphrontFailures are just title/body, I can replace with Dialog. | |
Comment Actions
Oh -- it looks like PhabricatorDisabledUserController uses this too. But that should also just return a plain dialog.
Really, we could make 403, 404 and DisabledUser all just return a dialog and then remove this class completely.
Comment Actions
(Since some of this stuff isn't in controllers, my advice above is a little off -- you can't use the newDialog() convenience function when not inside a controller, and will have to do it the verbose way: id(new AphrontDialogView())->setUser($user)->...)
Comment Actions
hrm, getting an error when testing disabled users.
>>> UNRECOVERABLE FATAL ERROR <<< Call to undefined method PhutilSafeHTML::setRequest() /Users/familyroom/Sites/phabricator/src/applications/base/controller/PhabricatorController.php:318 ┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻
| src/applications/auth/controller/PhabricatorDisabledUserController.php | ||
|---|---|---|
| 17–29 ↗ | (On Diff #25413) | Oh, sorry. For this, just do: return $this->newDialog() ->setTitle(...) ->addCancelButton(...) ->appendParagraph(...); You don't need to build a page view or render it here. |