Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15492775
D10578.id25405.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D10578.id25405.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -28,7 +28,7 @@
'rsrc/css/aphront/pager-view.css' => '2e3539af',
'rsrc/css/aphront/panel-view.css' => '5846dfa2',
'rsrc/css/aphront/phabricator-nav-view.css' => '9283c2df',
- 'rsrc/css/aphront/request-failure-view.css' => '7a83dc3a',
+ 'rsrc/css/aphront/request-failure-view.css' => '91e43caf',
'rsrc/css/aphront/table-view.css' => 'b22b7216',
'rsrc/css/aphront/tokenizer.css' => '82ce2142',
'rsrc/css/aphront/tooltip.css' => '9c90229d',
@@ -506,7 +506,7 @@
'aphront-multi-column-view-css' => '1b95ab2e',
'aphront-pager-view-css' => '2e3539af',
'aphront-panel-view-css' => '5846dfa2',
- 'aphront-request-failure-view-css' => '7a83dc3a',
+ 'aphront-request-failure-view-css' => '91e43caf',
'aphront-table-view-css' => 'b22b7216',
'aphront-tokenizer-control-css' => '82ce2142',
'aphront-tooltip-css' => '9c90229d',
diff --git a/src/view/page/AphrontRequestFailureView.php b/src/view/page/AphrontRequestFailureView.php
--- a/src/view/page/AphrontRequestFailureView.php
+++ b/src/view/page/AphrontRequestFailureView.php
@@ -13,15 +13,15 @@
final public function render() {
require_celerity_resource('aphront-request-failure-view-css');
- $head = phutil_tag_div(
- 'aphront-request-failure-head',
- phutil_tag('h1', array(), $this->header));
-
$body = phutil_tag_div(
'aphront-request-failure-body',
$this->renderChildren());
- return phutil_tag_div('aphront-request-failure-view', array($head, $body));
+ $box = id(new PHUIObjectBoxView())
+ ->setHeaderText($this->header)
+ ->appendChild($body);
+
+ return phutil_tag_div('aphront-request-failure-view', $box);
}
}
diff --git a/webroot/rsrc/css/aphront/request-failure-view.css b/webroot/rsrc/css/aphront/request-failure-view.css
--- a/webroot/rsrc/css/aphront/request-failure-view.css
+++ b/webroot/rsrc/css/aphront/request-failure-view.css
@@ -3,43 +3,33 @@
*/
.aphront-request-failure-view {
- margin: 16px auto;
- background: #eff2f7;
+ margin: 32px auto;
width: 600px;
}
.device .aphront-request-failure-view {
- width: 90%;
-}
-
-.aphront-request-failure-view .aphront-request-failure-head {
- padding: 1em 2em;
- border-bottom: 1px solid #afb2b7;
- background: #dfe2e7;
-}
-
-.aphront-request-failure-view .aphront-request-failure-head h1 {
- font-size: 24px;
+ width: 100%;
+ margin: 24px 0;
}
.aphront-request-failure-view .aphront-request-failure-body {
- padding: 1em 2em 1.5em;
+ padding: 12px;
}
.aphront-request-failure-view .aphront-request-failure-body p {
- margin: .5em 0;
+ margin: 4px 0;
}
.aphront-failure-continue {
- margin-top: 1.5em;
+ margin-top: 12px;
text-align: right;
}
.aphront-failure-continue a.button {
- margin-left: 1em;
+ margin-left: 8px;
}
.aphront-request-failure-view ul {
list-style: disc;
- margin-left: 3em;
+ margin-left: 16px;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Apr 13, 6:11 PM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7704223
Default Alt Text
D10578.id25405.diff (2 KB)
Attached To
Mode
D10578: Update AphrontRequestFailure to common display libs
Attached
Detach File
Event Timeline
Log In to Comment