Page MenuHomePhabricator
Differential D10549

Support - Differential - fix rendering feed story where you removed a repository
ClosedPublic
Actions

Authored by btrahan on Sep 24 2014, 6:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 5:48 AM
Unknown Object (File)
Wed, Dec 11, 6:07 AM
Unknown Object (File)
Sun, Dec 8, 11:55 AM
Unknown Object (File)
Sat, Dec 7, 1:09 PM
Unknown Object (File)
Thu, Dec 5, 7:17 AM
Unknown Object (File)
Sat, Nov 30, 2:16 PM
Unknown Object (File)
Fri, Nov 22, 3:19 PM
Unknown Object (File)
Oct 18 2024, 10:28 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T6176: Recent Activity Feed Render Failure
Commits
Restricted Diffusion Commit
rP93e1978e0548: Support - Differential - fix rendering feed story where you removed a repository
Summary

Fixes T6176. Language here is a bit awkard but I wanted to use the verb "removed" *and* still have the object first, so I ended up adding the before details parenthetically.

Test Plan

story no longer fatal'd in my feed

Diff Detail

Repository
rP Phabricator
Branch
T6176
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2623
Build 2627: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25338.Sep 24 2014, 6:36 PM
btrahan added a task: T6176: Recent Activity Feed Render Failure.
btrahan retitled this revision from to Support - Differential - fix rendering feed story where you removed a repository.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptSep 24 2014, 6:36 PM
Harbormaster completed remote builds in B2623: Diff 25338.Sep 24 2014, 6:37 PM
chad accepted this revision.Sep 24 2014, 6:53 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 24 2014, 6:53 PM
Closed by commit rP93e1978e0548: Support - Differential - fix rendering feed story where you removed a repository (authored by btrahan, committed by btrahan).Sep 24 2014, 7:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
customfield/
10 lines

Diff 25338

View Options

src/applications/differential/customfield/DifferentialRepositoryField.php

Loading...
Phabricator · Built by Phacility