Differential D10506

Provide more logging for Drydock blueprints (EC2, etc)
AbandonedPublic
Actions

Authored by hach-que on Sep 17 2014, 4:08 AM.

Tags

None

Referenced Files

	F17682454: D10506.id25243.diff
	Sun, Jul 13, 8:42 PM

	F17677484: D10506.id25248.diff
	Sun, Jul 13, 12:01 PM

	F17666456: D10506.id25245.diff
	Sat, Jul 12, 9:30 PM

	F17651781: D10506.id27537.diff
	Sat, Jul 12, 6:04 AM

	F17644812: D10506.diff
	Fri, Jul 11, 11:03 PM

	F17625282: D10506.diff
	Thu, Jul 10, 3:09 AM

	Unknown Object (File)
	Jun 6 2025, 10:30 AM

	Unknown Object (File)
	May 19 2025, 8:28 AM

Subscribers

• jon.krawczuk

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T2015: Implement Drydock

Summary

Ref T2015. This provides detailed logging for blueprint implementations, such as the min-max and expiry behaviour, and detailed logs as EC2 instances are allocated.

Test Plan

Tested it locally.

Diff Detail

Repository

Branch

patch-stack

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2557
Build 2561: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 25243.Sep 17 2014, 4:08 AM

hach-que retitled this revision from to Provide more logging for Drydock blueprints (EC2, etc).

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T2015: Implement Drydock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 17 2014, 4:08 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2555: Diff 25243.Sep 17 2014, 4:09 AM

hach-que added inline comments.Sep 17 2014, 4:10 AM

src/applications/drydock/storage/DrydockLog.php
63–77	I had to modify these since resources and leases can be hard deleted when they fail to allocate. Arguably in this scenario the resources / leases should be moved to broken rather than hard deleted.

Rebase

Harbormaster completed remote builds in B2557: Diff 25245.Sep 17 2014, 6:30 AM

Rebase

Harbormaster completed remote builds in B2560: Diff 25248.Sep 17 2014, 6:42 AM

Please proceed, great implementation

hach-que removed a reviewer: • jon.krawczuk.Sep 17 2014, 5:12 PM

• jon.krawczuk requested changes to this revision.Sep 17 2014, 6:31 PM

• jon.krawczuk added a reviewer: • jon.krawczuk.

This revision now requires changes to proceed.Sep 17 2014, 6:31 PM

hach-que removed a reviewer: • jon.krawczuk.Sep 17 2014, 8:31 PM

hach-que mentioned this in D10874: Improve Drydock log search engine.Nov 22 2014, 8:13 AM

hach-que mentioned this in D10892: [drydock/core] Add blueprint PHID to Drydock logs.Nov 22 2014, 8:21 AM

Remove components that were moved into D10892

Harbormaster completed remote builds in B3152: Diff 26206.Dec 1 2014, 1:28 AM

Rebase

joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 4:55 AM

devurandom added a subscriber: devurandom.Mar 2 2015, 8:40 PM

Depends on premature changes.

This revision now requires changes to proceed.Aug 8 2015, 6:18 PM

hach-que abandoned this revision.Dec 3 2015, 9:34 AM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140917.drydocklogblueprint.1.sql

2 lines

src/

applications/

drydock/

blueprint/

DrydockAmazonEC2HostBlueprintImplementation.php

269 lines

DrydockBlueprintImplementation.php

15 lines

DrydockMinMaxBlueprintImplementation.php

28 lines

DrydockMinMaxExpiryBlueprintImplementation.php

23 lines

controller/

DrydockResourceCloseController.php

1 line

query/

DrydockLogQuery.php

36 lines

storage/

21 lines

view/

DrydockLogListView.php

41 lines

worker/

DrydockAllocatorWorker.php

18 lines

Diff 25245

resources/sql/autopatches/20140917.drydocklogblueprint.1.sql

Loading...

src/applications/drydock/blueprint/DrydockAmazonEC2HostBlueprintImplementation.php

Loading...

src/applications/drydock/blueprint/DrydockBlueprintImplementation.php

Loading...

src/applications/drydock/blueprint/DrydockMinMaxBlueprintImplementation.php

Loading...

src/applications/drydock/blueprint/DrydockMinMaxExpiryBlueprintImplementation.php

Loading...

src/applications/drydock/controller/DrydockResourceCloseController.php

Loading...

src/applications/drydock/query/DrydockLogQuery.php

Loading...

src/applications/drydock/storage/DrydockLog.php

Loading...

src/applications/drydock/view/DrydockLogListView.php

Loading...

src/applications/drydock/worker/DrydockAllocatorWorker.php

Loading...