Fixes T5966. Accomplishes a few things
- see title
- adds a force-autoclose flag and the plumbing for it
- removes references to some HarborMaster thing that used to key off commits and seems long dead, but forgotten :/
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T5966: Move scripts/repository/reparse.php to bin/repository reparse
- Commits
- Restricted Diffusion Commit
rP648fa2e1bcc6: Repositories - Move scripts/repository/reparse.php to bin/repository reparse
ran a few commands. These first three had great success:
./repository reparse --all FIRSTREPO --message --change --herald --owners
./repository reparse --all FIRSTREPO --message --change --herald --owners --min-date yesterday
./repository reparse --all FIRSTREPO --message --change --herald --owners --min-date yesterday --force-autoclose
...and these next two showed me some errors as expected:
./repository reparse --all FIRSTREPO --message --change --herald --owners --min-date garbagedata
./repository reparse --all GARBAGEREPO --message --change --herald --owners
Also, made a diff in a repository with autoclose disabled and commited the diff. Later, reparse the diff with force-autoclose. Verified the diff closed and that the reason "why" had the proper message text.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T5966
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 2531 Build 2535: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php | ||
|---|---|---|
| 14–20 | Old help text | |
| 23 | cruft? | |
| 139 | Old help string. | |
| 196–227 | This could happen later, but DiffusionCommitQuery should be able to do a much better job of this now (and work for short commit hashes, and not require the repository be specified for unambiguous commits). | |
| src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php | ||
| 86 | We should add a REASON_FORCED here and record/display it when it was forced. This will be confusing otherwise (autoclose effects with a UI message like "didn't autoclose because <some reason>"). That is: if ($force_autoclose) {
$autoclose_reason = PhabricatorRepository::BECAUSE_FORCED;
}...then you might have to tweak the UI a bit where we show this stuff in Diffusion, because all of the current reasons are negative ("No: here's why") but this one is positive ("Yes: you passed a flag"). | |
Comment Actions
Implemented changes EXCEPT switching to DiffusionCommitQuery, which was a nice to have code re-factor thing which would require a good bit of testing.