Page MenuHomePhabricator

Transactions - hide "mentioned in X" story if you can't see X
ClosedPublic

Authored by btrahan on Sep 12 2014, 5:51 PM.
Tags
None
Referenced Files
F13333582: D10488.diff
Tue, Jun 18, 8:01 AM
F13299884: D10488.diff
Fri, Jun 7, 8:32 AM
F13285366: D10488.diff
Mon, Jun 3, 7:26 PM
F13277244: D10488.diff
Fri, May 31, 9:41 AM
F13261561: D10488.diff
Mon, May 27, 1:11 AM
F13244160: D10488.diff
May 23 2024, 4:34 AM
F13230540: D10488.id25211.diff
May 20 2024, 11:02 PM
F13222686: D10488.diff
May 19 2024, 3:52 AM
Subscribers

Details

Summary

...also re-jiggers all the anchor stuff to use $xaction ID. This seemed like the simplest way once I got in the code, as well as having nice properties for if / when we want to re-add some ajax stuff since the ID is a pretty solid piece of data to key off. Fixes T6083.

Test Plan

mentioned DX in private DX+1. Could see on DX the mention as me and not as the other user. For transactions, I left a comment on Paste and it worked, and I edited an existing transaction and it worked.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Transactions - hide "mentioned in X" story if you can't see X.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

It sucks that this breaks existing anchors and that we get not-so-nice anchors going forward, but I agree that this is probably the best approach in the long term.

This revision is now accepted and ready to land.Sep 14 2014, 1:31 PM

T4712 seems like it makes doing this a must.

This revision was automatically updated to reflect the committed changes.