Differential D10474

Add a bunch of additional test cases for `ArcanistTextLinter`
ClosedPublic
Actions

Authored by joshuaspence on Sep 11 2014, 12:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 4, 1:54 AM

	Unknown Object (File)
	Sun, Feb 2, 2:33 AM

	Unknown Object (File)
	Thu, Jan 30, 3:45 AM

	Unknown Object (File)
	Tue, Jan 28, 11:21 AM

	Unknown Object (File)
	Tue, Jan 28, 9:16 AM

	Unknown Object (File)
	Fri, Jan 24, 2:32 PM

	Unknown Object (File)
	Thu, Jan 23, 10:39 AM

	Unknown Object (File)
	Wed, Jan 22, 3:10 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCf4fd7ad612a9: Add a bunch of additional test cases for `ArcanistTextLinter`

Summary

Self-explanatory, improve test coverage.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 25186.Sep 11 2014, 12:37 PM

joshuaspence retitled this revision from to Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 11 2014, 12:37 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2510: Diff 25186.Sep 11 2014, 12:37 PM

epriestley accepted this revision.Sep 11 2014, 12:38 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 11 2014, 12:38 PM

joshuaspence retitled this revision from Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL` to Add a bunch of additional test cases for `ArcanistTextLinter`.Sep 11 2014, 12:54 PM

joshuaspence edited edge metadata.

Add a bunch of other test cases

I chucked a few extras in here

Harbormaster completed remote builds in B2511: Diff 25187.Sep 11 2014, 12:55 PM

epriestley accepted this revision.Sep 11 2014, 1:27 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 11 2014, 1:27 PM

joshuaspence retitled this revision from Add a test case for `ArcanistTextLinter::LINT_TAB_LITERAL` to Add a bunch of additional test cases for `ArcanistTextLinter`.Sep 11 2014, 1:43 PM

joshuaspence edited edge metadata.

Closed by commit rARCf4fd7ad612a9 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

text/

bad-charset.lint-test

3 lines

line-wrap.lint-test

6 lines

trailing-whitespace.lint-test

8 lines

Diff 25202

src/lint/linter/tests/text/bad-charset.lint-test

Loading...

src/lint/linter/tests/text/line-wrap.lint-test

Loading...

src/lint/linter/tests/text/trailing-whitespace.lint-test

Loading...