Page MenuHomePhabricator

Transactions - don't let objects mention themselves.
ClosedPublic

Authored by btrahan on Sep 10 2014, 5:13 PM.
Tags
None
Referenced Files
F15178610: D10464.id25162.diff
Wed, Feb 19, 10:34 AM
Unknown Object (File)
Fri, Feb 7, 11:04 PM
Unknown Object (File)
Fri, Feb 7, 11:04 PM
Unknown Object (File)
Fri, Feb 7, 11:04 PM
Unknown Object (File)
Fri, Feb 7, 11:03 PM
Unknown Object (File)
Fri, Feb 7, 11:03 PM
Unknown Object (File)
Wed, Feb 5, 10:15 PM
Unknown Object (File)
Sun, Feb 2, 3:51 AM
Subscribers

Details

Summary

Fixes T6059.

Test Plan

Made a comment on TX mentioning TX and TX+1. TX did not get a "mentioned" transaction while TX+1 did.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Transactions - don't let objects mention themselves..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
1214–1218

I think $object->getPHID() is potentially null here (i.e., this code can run during creation of a new object, before the object is saved). We'll still get the right result since it's impossible to mention a nonexistent object, but adding an explicit if ($object->getPHID()) { ... } check might make this more clear some day down the line.

This revision is now accepted and ready to land.Sep 10 2014, 5:17 PM
btrahan edited edge metadata.
  • add $object->getPHID() && to if conditional for clarity
  • slap a comment on there too
btrahan updated this revision to Diff 25166.

Closed by commit rP13834f140617 (authored by @btrahan).