Page MenuHomePhabricator

Show a count (like "(3)") in the page title corresponding to unread notifications/messages
ClosedPublic

Authored by epriestley on Sep 9 2014, 11:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 22, 7:29 AM
Unknown Object (File)
Wed, Nov 16, 7:28 PM
Unknown Object (File)
Wed, Nov 16, 5:57 PM
Unknown Object (File)
Mon, Nov 14, 12:22 PM
Unknown Object (File)
Wed, Nov 9, 11:12 AM
Unknown Object (File)
Wed, Nov 9, 3:29 AM
Unknown Object (File)
Tue, Nov 8, 8:11 PM
Unknown Object (File)
Tue, Nov 8, 8:11 PM

Details

Summary

Fixes T5368. Synchronizes the page title to reflect unread counts in the notification and Conphernece messages menus.

Test Plan

Screen_Shot_2014-09-09_at_4.31.44_PM.png (394×1 px, 91 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Show a count (like "(3)") in the page title corresponding to unread notifications/messages.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 10 2014, 5:16 PM
epriestley updated this revision to Diff 25163.

Closed by commit rP568b0e06e7d5 (authored by @epriestley).

the majority of users at our site would prefer to disable this.
could it be made into a config option?

Not very likely, we are fairly opinionated that "Options" (and the cost of maintaining/supporting/documenting) are very bad and are detrimental to a project the size of Phabricator and avoid them as much as possible. In cases like this, recommend a local patch or fork.

Is there any reasoning as to how come they would want to disable it?

Is there any reasoning as to how come they would want to disable it?

the count is transient data that has no bearing on
what the page contains, page titles should describe the page.
if you've got a few tabs open, you only see the first few chars of each title,
which should be something that uniquely identifies what's in the tab,
e.g. task/diff ID, what was previously first, and follows the Notifications.