Page MenuHomePhabricator
Differential D10449

Support "tel:" protocol in Remarkup
ClosedPublic
Actions

Authored by epriestley on Sep 9 2014, 3:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 5:26 PM
Unknown Object (File)
Wed, Dec 18, 1:59 PM
Unknown Object (File)
Fri, Dec 13, 7:25 AM
Unknown Object (File)
Wed, Dec 11, 11:27 PM
Unknown Object (File)
Fri, Dec 6, 3:35 PM
Unknown Object (File)
Thu, Dec 5, 5:42 AM
Unknown Object (File)
Wed, Dec 4, 4:13 PM
Unknown Object (File)
Sun, Dec 1, 6:38 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6057: Remarkup recognising tel: URIs in hyperlinks
Commits
rPHUecf3526e557f: Support "tel:" protocol in Remarkup
Summary

Fixes T6057.

Test Plan

Added and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
telproto
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2473
Build 2477: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25134.Sep 9 2014, 3:51 PM
epriestley retitled this revision from to Support "tel:" protocol in Remarkup.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6057: Remarkup recognising tel: URIs in hyperlinks.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 9 2014, 3:51 PM
Harbormaster completed remote builds in B2473: Diff 25134.Sep 9 2014, 3:52 PM
btrahan accepted this revision.Sep 10 2014, 5:15 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 10 2014, 5:15 PM
epriestley closed this revision.Sep 10 2014, 5:18 PM
epriestley updated this revision to Diff 25164.

Closed by commit rPHUecf3526e557f (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
markup/
__tests__/
1 line
engine/
__tests__/
1 line
remarkup/
18 lines
remarkup/
markuprule/
13 lines

Diff 25134

View Options

src/markup/__tests__/PhutilMarkupTestCase.php

Loading...
View Options

src/markup/engine/__tests__/PhutilRemarkupEngineTestCase.php

Loading...
View Options

src/markup/engine/__tests__/remarkup/link-tel.txt

Loading...
View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupDocumentLinkRule.php

Loading...
Phabricator · Built by Phacility