Maniphest - upgrade merging to real transactions
ClosedPublic
Actions

Authored by btrahan on Sep 5 2014, 11:38 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5875: "Close Revision" and "Merge Task" interactions should be real transactions, not comments

Commits

Restricted Diffusion Commit
rPfdccb0f40536: Maniphest - upgrade merging to real transactions

Summary

see title. Ref T5875.

Test Plan

Merged one task into another task - verified transactions on both tasks. Merged two tasks into another task - verified transactions on all three tasks. Checked out my feed and saw MERGE_INTO stories and MERGE_FROM stories.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 25086.Sep 5 2014, 11:38 PM

btrahan added a task: T5875: "Close Revision" and "Merge Task" interactions should be real transactions, not comments.

btrahan retitled this revision from to Maniphest - upgrade merging to real transactions.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptSep 5 2014, 11:38 PM

Harbormaster completed remote builds in B2445: Diff 25086.Sep 5 2014, 11:38 PM

Story works OK for me with inline fix. I got a story pointing me to this ("Exception rendering story..."), maybe you overlooked that? It's also possibly we only show it in dev mode or something and you have some flag off...

Screen_Shot_2014-09-08_at_7.38.31_AM.png (228×668 px, 29 KB)

src/applications/maniphest/storage/ManiphestTransaction.php
863	This should be `Handle`, not `Hande`.

This revision is now accepted and ready to land.Sep 8 2014, 2:39 PM

epriestley awarded a token.Sep 8 2014, 2:39 PM

chad awarded a token.Sep 8 2014, 3:32 PM

fix typo

(The stories werent' working for me because my task that kept getting stronger had visibility set to "no one". As such, feed stories where it was the primary object were not being loaded correctly. Yay crappy test data. =D )

btrahan updated this object.Sep 8 2014, 9:11 PM

btrahan edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B2470: Diff 25125.Sep 8 2014, 9:11 PM