see title. Ref T5875.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T5875: "Close Revision" and "Merge Task" interactions should be real transactions, not comments
- Commits
- Restricted Diffusion Commit
rPfdccb0f40536: Maniphest - upgrade merging to real transactions
Merged one task into another task - verified transactions on both tasks. Merged two tasks into another task - verified transactions on all three tasks. Checked out my feed and saw MERGE_INTO stories and MERGE_FROM stories.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T5875
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2470 Build 2474: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Story works OK for me with inline fix. I got a story pointing me to this ("Exception rendering story..."), maybe you overlooked that? It's also possibly we only show it in dev mode or something and you have some flag off...
| src/applications/maniphest/storage/ManiphestTransaction.php | ||
|---|---|---|
| 863 | This should be Handle, not Hande. | |
Comment Actions
- fix typo
(The stories werent' working for me because my task that kept getting stronger had visibility set to "no one". As such, feed stories where it was the primary object were not being loaded correctly. Yay crappy test data. =D )