Page MenuHomePhabricator

Don't require an actor in `PhabricatorFile::attachToObject()`
ClosedPublic

Authored by epriestley on Sep 4 2014, 4:24 PM.
Tags
None
Referenced Files
F14064891: D10412.diff
Tue, Nov 19, 1:47 AM
F14030026: D10412.id25069.diff
Fri, Nov 8, 11:09 PM
F14018096: D10412.id.diff
Tue, Nov 5, 4:37 AM
F14009655: D10412.id25069.diff
Wed, Oct 30, 10:13 PM
F13991936: D10412.id25069.diff
Tue, Oct 22, 1:25 PM
F13991440: D10412.id25055.diff
Tue, Oct 22, 10:51 AM
F13991236: D10412.id.diff
Tue, Oct 22, 9:26 AM
F13991014: D10412.id25055.diff
Tue, Oct 22, 8:08 AM

Details

Summary

Ref T6013. A very long time ago, edges were less clearly low-level infrastructure, and some user-aware stuff got built around edge edits.

This was kind of a mess and I eventually removed it, during or prior to T5245. The big issue was that control flow was really hard to figure out as things went all the way down to the deepest level of infrastructure and then came back up the stack to events and transactions. The new stuff is more top-down and generally seems a lot easier and cleaner.

Consequently, actors are no longer required for edge edits. Remove the parameter.

Test Plan

Poked around; ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't require an actor in `PhabricatorFile::attachToObject()`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 4 2014, 7:30 PM
epriestley updated this revision to Diff 25069.

Closed by commit rP3af442e4ac94 (authored by @epriestley).